Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

코드 리팩토링 #42

Merged
merged 4 commits into from
Oct 5, 2023
Merged

코드 리팩토링 #42

merged 4 commits into from
Oct 5, 2023

Conversation

seokwns
Copy link
Contributor

@seokwns seokwns commented Oct 5, 2023

작업 내용

  • 응답 DTO 파일을 하나로 통합시켰습니다

주의 사항(Optional)

  • delete mapping을 id 받아서 삭제하려면 해당 포트폴리오를 조회해서 플래너 id와 비교하는 로직이 필요한데, 이렇게 하면 select 쿼리를 추가로 발생해야 하는 문제점이 생깁니다 ..! 고민해보면 좋을 것 같아서 남겨봅니당

Rizingblare and others added 3 commits October 2, 2023 16:14
@Rizingblare
Merge pull request Step3-kakao-tech-campus#32 from Step3-kakao-tech-c…
f903e29 
…ampus/weekly

부산대_5조_순수웨딩_4주차_DEVELOP_#2
@Rizingblare
Merge pull request Step3-kakao-tech-campus#33 from Step3-kakao-tech-c…
d2b12e7 
…ampus/develop

부산대_5조_순수웨딩_4주차_MASTER_#2
@seokwns
refactor: DTO files and annotation refactoring
4238285 
- DTO 파일들을 PortoflioResponse 파일로 통합
- 어노테이션 정리
@seokwns seokwns added In-progress 진행 중 portfolio 포트폴리오 관련 기능 labels Oct 5, 2023
1jeongg
1jeongg approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@1jeongg 1jeongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훨씬 깔끔해졌네요! 고생하셨어요 👍👍

@1jeongg 1jeongg merged commit 5869283 into Step3-kakao-tech-campus:weekly Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1jeongg 1jeongg 1jeongg approved these changes

Assignees
No one assigned
Labels
In-progress 진행 중 portfolio 포트폴리오 관련 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seokwns @1jeongg @Rizingblare