-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PlayCount Plugin #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please properly gitignore your dist folder from the repo, update your DFL dependency to the latest version. An update to match the websockets plugin template is not required but is highly recommended. You would be able to drop any python at that point as well.
I'm pretty sure that these are the only changes needed.
|
Moved to the latest decky plugin template :) Thanks to all the supporters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Off to testing.
Lock file added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image needs to be changed to an actual URL in plugin.json, once that's done the plugin will actually finish CI/CD.
Added an actual URL in plugin.json as requested by Train! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already in testing, but giving it official stamp.
The plugin does not properly remove the injected banner into the app page, resulting in multiple layered banners when the plugin is reloaded or uninstalled. |
Wdym frog can you please explain everything seems to be working fine on my end woth no duplication. |
The easiest way to test it is uninstall the plugin. Then navigate to the app page and the playcount banner is still there. I think this is incorrect: It should be something like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The easiest way to test it is uninstall the plugin. Then navigate to the app page and the playcount banner is still there.
I think this is incorrect: https://github.com/itsOwen/playcount-decky/blob/aa62d6af42cbc0cd681ec12d596cd12a255156bc/src/patches/LibraryPatch.ts#L120
It should be something like this:
routerHook.removePatch('/library/app/:appid', unpatch);
I am considering this a blocking issue until resolved.
…t not appearing on delly footer
Testing ReportVersionsDecky: v3.1.2-pre1 SummaryMajor blocking issues
Minor issues
Currently installed plugins
Yay/nay on to send to the production store or if it requires more testing.
|
edit: do you mean menu button and select A button flickering? If yes then I dont see it either. I will keep trying to reproduce the issue. |
yeah I believe you a some issue with your footer patching. Here is one example where the footer items disappear. It seems to happen in specific cases, but it's a bit unpredictable what those are. So far it seems reliably reproducible when first starting the store and also when navigating to a game page (in the store) and then reloading the store (as demonstrated in video). There may be other cases and imo further testing is necessary. |
Decky-Recorder_2025-01-14_04-19-07.mp4@jessebofill @Tormak9970 So I tested the issue you were discussing. I think the problem might be with the Decky Loader pre1 itself, but I'm not sure. I uninstalled all plugins, uninstalled Decky Loader, and reinstalled Decky. After that, I tested the issue and confirmed it's unrelated to my plugin or any other plugin, as it happens without them. So I installed Decky Recorder and recorded it for you. |
I just tested and weirdly enough it does happen without the plugin installed. I checked that earlier twice, and it functioned fine. Since that's the case the plugin looks good to me 👍 |
@Tormak9970 @TrainDoctor @jessebofill Okay, so after thorough testing, I think I've found the issue; it's related to the latest stable version of SteamOS itself. What I did:
|
Yeah that makes sense. In that case here's my official report. Testing ReportVersionsDecky: v3.1.2-pre1 SummaryMajor blocking issuesNone Minor issuesNone Currently installed plugins
Yay/nay on to send to the production store or if it requires more testing.Yay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With issues resolved from earlier commits, and flickering bug confirmed to be unrelated to Decky or this plugin (including any UI patching this plugin performs) by testers, it looks like production is a go ahead.
Plugin Description
PlayCount is a Steam Deck plugin that shows real-time player counts for Steam games directly in the UI. It helps users see how active a game's community is before launching.
Features
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Tested on SteamOS Stable Update Channel.
or
Tested on SteamOS Beta Update Channel.
✅ No special dependencies required
✅ No known conflicts with other plugins
Additional Notes