Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Navigation): Fix navigation for chromium 109 beta #100

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

beebls
Copy link
Contributor

@beebls beebls commented Jan 20, 2024

The January 18th beta, which updated CEF to chromuim 109, changed just enough of the internal navigation code to absolutely ruin everything. This PR fixes Navigation.

I have tested every single method on the Navigation object and they all work on the latest beta, I have also tested this on a deck running Stable, and it still works.

Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeebles

@AAGaming00 AAGaming00 merged commit 0351d75 into main Jan 20, 2024
1 check passed
beebls added a commit that referenced this pull request Jan 20, 2024
@TrainDoctor TrainDoctor deleted the beebls/chromium-109-fixes branch January 20, 2024 02:59
github-actions bot pushed a commit to shdwmtr/plugutil that referenced this pull request Dec 1, 2024
# 1.0.0 (2024-12-01)

### Bug Fixes

* add patch indicator to prevent crashes ([3170779](3170779))
* add patch indicator to prevent crashes ([SteamDeckHomebrew#88](https://github.com/shdwmtr/plugutil/issues/88)) ([9128c1e](9128c1e))
* Another CI fix ([c831aa9](c831aa9))
* Another CI fix (again) ([c5da6a2](c5da6a2))
* **button:** add style prop ([d6a08fe](d6a08fe))
* **Button:** add types to DialogButton ([29201fa](29201fa))
* **ButtonItem:** update to account for both prop settings ([6be0644](6be0644))
* **classes:** add gamepadDialogClasses and quickAccessControlsClasses ([2e7b4b6](2e7b4b6))
* **classes:** switch static-classes to findModule ([244ae12](244ae12))
* **components:** component rename ([f5da0c6](f5da0c6))
* **components:** export FIeld ([a87e1bb](a87e1bb))
* **decky:** fix decky on latest beta ([74a7cba](74a7cba))
* **deps:** Fix dependency issue ([af03860](af03860))
* **DialogButton:** fix ref type ([74aefc7](74aefc7))
* **DialogButton:** fix types, add ref types ([db41e74](db41e74))
* **Dialog:** remove not exported dialog button ([SteamDeckHomebrew#37](https://github.com/shdwmtr/plugutil/issues/37)) ([5a5218a](5a5218a))
* **docs:** build each component as a seperate page ([fbd936d](fbd936d))
* **docs:** change arg format ([ed0b92d](ed0b92d))
* **docs:** set categorizeByGroup to true ([0f205e8](0f205e8))
* **Dropdown:** correct Dropdown types ([SteamDeckHomebrew#15](https://github.com/shdwmtr/plugutil/issues/15)) ([a09af35](a09af35))
* **Field:** add override for onClick type ([SteamDeckHomebrew#43](https://github.com/shdwmtr/plugutil/issues/43)) ([fe75dfb](fe75dfb))
* **Field:** add types for focusing field ([SteamDeckHomebrew#41](https://github.com/shdwmtr/plugutil/issues/41)) ([bedb6b8](bedb6b8))
* **Field:** description is a string you idiot ([4697749](4697749))
* **Field:** fix this time for real ([SteamDeckHomebrew#44](https://github.com/shdwmtr/plugutil/issues/44)) ([cfef1dc](cfef1dc))
* **FieldProps:** Add "bottomSeparator" option ([SteamDeckHomebrew#16](https://github.com/shdwmtr/plugutil/issues/16)) ([490a1f7](490a1f7))
* **Field:** remove incompatible properties ([SteamDeckHomebrew#42](https://github.com/shdwmtr/plugutil/issues/42)) ([0010a1f](0010a1f))
* **Field:** remove style ([53faf55](53faf55))
* **Field:** title -> label ([da4c79b](da4c79b))
* **finds:** make modal and scroll components work on latest betaa ([c2b0fad](c2b0fad))
* **findSP:** fallback to last active context ([SteamDeckHomebrew#53](https://github.com/shdwmtr/plugutil/issues/53)) ([6f14da1](6f14da1))
* Fix bugs introduced in Steam beta ([fee77b5](fee77b5))
* Fix semantic release ([46a9c34](46a9c34))
* Fix terser bug causing function ambiguity ([c1bb500](c1bb500))
* Fix TTC crashing when a plugin contains no webkit ([e43d5ab](e43d5ab))
* Fix webkit shim calling _front_end_load ([0d5a523](0d5a523))
* fixed missing export ([b480d39](b480d39))
* fixed prop interfaces ([SteamDeckHomebrew#70](https://github.com/shdwmtr/plugutil/issues/70)) ([0b50f2c](0b50f2c))
* **Focusable:** add ref prop, fix event types ([f1e20cd](f1e20cd))
* **Footer:** add types for ActionDescriptionMap ([2ec9519](2ec9519))
* **FooterLegend:** change description types to ReactNode ([SteamDeckHomebrew#62](https://github.com/shdwmtr/plugutil/issues/62)) ([d24136e](d24136e))
* General bug fixes ([970b1cd](970b1cd))
* generic bug fixes ([ccde4e9](ccde4e9))
* **husky:** wrong script for husky caused problems when installing ([bc2bec4](bc2bec4))
* **Item:** add highlightOnFocus prop ([c53f87b](c53f87b))
* **Item:** change title and description types to ReactNode ([0ed054f](0ed054f))
* **License:** update license in package.json ([064c161](064c161))
* list didn't update on prop change ([b146eab](b146eab))
* **Marquee:** replace default export with named export ([cd0635e](cd0635e))
* **Menu:** fix on Steam beta ([82768e0](82768e0))
* missing parameter ([8b54ee9](8b54ee9))
* **Modal:** add another prop ([2fdfcdd](2fdfcdd))
* **Modal:** add closeModal ([994b9e2](994b9e2))
* **Modal:** add more props to typings ([97997ad](97997ad))
* **modal:** allow children ([40871af](40871af))
* **modal:** extend props for modals ([SteamDeckHomebrew#32](https://github.com/shdwmtr/plugutil/issues/32)) ([1fbe55a](1fbe55a))
* **Modal:** fix on Steam beta ([e44187f](e44187f))
* **modal:** make children optional ([SteamDeckHomebrew#34](https://github.com/shdwmtr/plugutil/issues/34)) ([99ad754](99ad754))
* **modals:** fix ModalRoot again ([fd94842](fd94842))
* **modal:** update showModal types ([SteamDeckHomebrew#27](https://github.com/shdwmtr/plugutil/issues/27)) ([6996e54](6996e54))
* move the new file picker api as v2 ([8bfeae4](8bfeae4))
* **Navigation:** fix NavigateToExternalWeb ([82214fe](82214fe))
* **Navigation:** fix NavigateToExternalWeb ([c53d7f8](c53d7f8))
* **navigation:** Fix on chromium 109 ([SteamDeckHomebrew#100](https://github.com/shdwmtr/plugutil/issues/100)) ([ebf496b](ebf496b))
* **Navigation:** fix on stable ([4affd4a](4affd4a))
* **Navigation:** fix timing issue in decky-loader ([58b69f0](58b69f0))
* **package.json:** train wtf ([789e163](789e163))
* **package:** enable tree shaking ([58933f8](58933f8))
* **package:** fix pnpm peer dependencies errors ([e5e561e](e5e561e))
* **patcher:** why the hell did i do it that way ([2afb7f1](2afb7f1))
* **plugin:** correct return type on injectCssIntoTab ([1ce15d2](1ce15d2))
* **plugin:** export RoutePatch ([SteamDeckHomebrew#39](https://github.com/shdwmtr/plugutil/issues/39)) ([c44c66f](c44c66f))
* **plugin:** Export ServerResponse for use in plugin-loader.tsx ([SteamDeckHomebrew#20](https://github.com/shdwmtr/plugutil/issues/20)) ([d01c7b3](d01c7b3))
* **Plugin:** support non-ui plugins ([51c418d](51c418d))
* **ProgressBar:** extend correct prop type ([944a902](944a902))
* **QuickAccessTab:** set decky tab ID to 999 ([5d5cb31](5d5cb31))
* refactoring to fix for feb 22 2023 beta ([0b6dc24](0b6dc24))
* reorderable list no longer toggles on backout ([7e1182a](7e1182a))
* **reorderable-list:** open label type from string to ReactNode ([fb5f043](fb5f043))
* reposition parameter for file picker V2 ([ee51dc5](ee51dc5))
* **Router:** Add more members to Router interface ([SteamDeckHomebrew#12](https://github.com/shdwmtr/plugutil/issues/12)) ([7d3b5e8](7d3b5e8))
* **Router:** add NavigateBackOrOpenMenu() ([077334e](077334e))
* **Router:** add NavigateToStore to interface ([dd5c42c](dd5c42c))
* **Router:** fix Navigation for the millionth time ([aac2d52](aac2d52))
* **Router:** make specifying quick access tab not required ([7efc034](7efc034))
* **Router:** update Router interface to SteamOS3.4 and add Navigation ([SteamDeckHomebrew#52](https://github.com/shdwmtr/plugutil/issues/52)) ([f0379e5](f0379e5))
* **router:** wait 2s if internal navigators init fails ([95d977d](95d977d))
* **security:** update for minimist pollution exploit ([1de979f](1de979f))
* **ServerAPI:** add injectCssIntoTab to serverAPI typings ([823a274](823a274))
* **SidebarNavigation:** add more props ([SteamDeckHomebrew#29](https://github.com/shdwmtr/plugutil/issues/29)) ([ed0be5e](ed0be5e))
* **sidebarnavigation:** allow null pags ([d6b00b0](d6b00b0))
* **SidebarNavigation:** allow ReactNode for page title ([44d9b90](44d9b90))
* **sidebarnavigation:** no dont ([0ce1b54](0ce1b54))
* **spinners:** add SVG props ([24244f6](24244f6))
* **staticclasses:** unbreak on latest beta ([17b99df](17b99df))
* **SteamSpinner:** dont error on latest desktop beta ([19819b7](19819b7))
* **SteamSpinner:** fix the fix ([79d229b](79d229b))
* **SteamSpinner:** oh apparently the class was moved outside the component for some reason?????? ([b8ddf3d](b8ddf3d))
* **SuspensefulImage:** fix changing src ([9723854](9723854))
* **SuspensefulImage:** fix export ([dddb703](dddb703))
* **Tabs:** actually export it lmao ([0e0e0d2](0e0e0d2))
* **tabs:** fix on stable ([f16e0b2](f16e0b2))
* **tabs:** fix on stable for real this time i think ([a074277](a074277))
* **tabs:** fix props and add example ([4024b76](4024b76))
* **tabs:** it returns ([3c553a2](3c553a2))
* **Tabs:** make onShowTab required ([7161e75](7161e75))
* **tabs:** shut up typescript ([75f3588](75f3588))
* **Tabs:** temp remove until we have a way to grab it on beta ([25c33b2](25c33b2))
* **tabs:** unkill build ([3dbca1a](3dbca1a))
* **textfield:** correct type for onChange callback ([32c355f](32c355f))
* **textfield:** extend HTMLAttributes ([71c7afa](71c7afa))
* **TextFieldProps:** Add "disabled" option to TextFieldProps ([SteamDeckHomebrew#14](https://github.com/shdwmtr/plugutil/issues/14)) ([af98a76](af98a76))
* the typescript compiler was eating the enum ([c9b5839](c9b5839))
* total is not needed as a return value to plugins ([979a630](979a630))
* **types:** fix incorrect `as` on many components leading to any types ([bb12921](bb12921))
* **typings:** export all prop types ([7f9dfc5](7f9dfc5))
* un-break navigation on stable ([2e66e5a](2e66e5a))
* updates for webpack v5 ([a672230](a672230))
* **useQuickAccessVisible:** make it work again ([7dacb23](7dacb23))
* **useQuickAccessVisible:** make it work in beta ([SteamDeckHomebrew#49](https://github.com/shdwmtr/plugutil/issues/49)) ([e1f64a3](e1f64a3))
* **useQuickAccessVisible:** remove invalid prop access ([SteamDeckHomebrew#66](https://github.com/shdwmtr/plugutil/issues/66)) ([767dc2f](767dc2f))
* **useQuickAccessVisible:** use the "Page Visibility API" instead of focus/blur ([4c4fda4](4c4fda4))
* **utils/react:** support react 18, add getReactRoot ([11dd82b](11dd82b))
* **utils:** allow prop reassigns to fail ([a592883](a592883))
* **utils:** better method to wrap react classes ([e644de3](e644de3))
* **utils:** Mutable variable must be non-const ([SteamDeckHomebrew#19](https://github.com/shdwmtr/plugutil/issues/19)) ([1dd48cd](1dd48cd))
* **Utils:** return null when SP not found ([18d341f](18d341f))
* **utils:** update wrapReactClass impl. and defaults for prop argument ([SteamDeckHomebrew#17](https://github.com/shdwmtr/plugutil/issues/17)) ([55bd06a](55bd06a))
* **webpack:** don't break if a module fails to load ([5203ce3](5203ce3))
* **wrapReactType:** try another method ([b7dc1d6](b7dc1d6))

### Code Refactoring

* **components:** rename Field components ([9bd9622](9bd9622))

### Features

* Add better webkit support ([e01c177](e01c177))
* add components found while working on tabmaster ([4f8f65d](4f8f65d))
* add components found while working on tabmaster ([fd0d011](fd0d011))
* added doc comments ([dfcb3be](dfcb3be))
* added reorderable list and updated fieldProps ([3c171cf](3c171cf))
* added reorderable list and updated fieldProps ([SteamDeckHomebrew#57](https://github.com/shdwmtr/plugutil/issues/57)) ([5a074b5](5a074b5))
* better classmap ([0baff9c](0baff9c))
* changed ReorderableList to working version ([5b166d6](5b166d6))
* **classes:** add "appDetailsClasses" ([SteamDeckHomebrew#55](https://github.com/shdwmtr/plugutil/issues/55)) ([ed98d14](ed98d14))
* **classes:** add appDetailsHeaderClasses ([SteamDeckHomebrew#54](https://github.com/shdwmtr/plugutil/issues/54)) ([3229162](3229162))
* **classMapper:** add class mapper ([a8eeb91](a8eeb91))
* **components:** add Carousel component ([cf137c4](cf137c4))
* **components:** add Field ([7d82a82](7d82a82))
* **components:** add FocusRing ([b05f846](b05f846))
* **components:** add HorizontalFocus ([4d30efc](4d30efc))
* **components:** added shared item-props, progressbar, and more types for slider ([4328385](4328385))
* **components:** remove HorizontalFocus, add Focusable ([9beab5f](9beab5f))
* **ControlsList:** Add ControlsList component ([SteamDeckHomebrew#61](https://github.com/shdwmtr/plugutil/issues/61)) ([c586afb](c586afb))
* **custom-components:** add SuspensefulImage ([6324282](6324282))
* **Dialog:** add "focusable" button prop ([SteamDeckHomebrew#51](https://github.com/shdwmtr/plugutil/issues/51)) ([e167ef5](e167ef5))
* **DialogCheckbox:** Add DialogCheckbox component ([SteamDeckHomebrew#58](https://github.com/shdwmtr/plugutil/issues/58)) ([88f245d](88f245d))
* **dropdown:** add dropdown ([a99fb4a](a99fb4a))
* **Focusable:** add FooterLegend props to Focusable and Field ([c25fe58](c25fe58))
* **Focusable:** add noFocusRing prop type ([SteamDeckHomebrew#65](https://github.com/shdwmtr/plugutil/issues/65)) ([cc29dda](cc29dda))
* **FooterLegend:** add GamepadEvent ([130dfa2](130dfa2))
* **hooks:** Added useParams hook ([SteamDeckHomebrew#36](https://github.com/shdwmtr/plugutil/issues/36)) ([e2920dd](e2920dd))
* made requested changes and ran prettier ([b1b2f4f](b1b2f4f))
* **Marquee:** Add Marquee component ([SteamDeckHomebrew#63](https://github.com/shdwmtr/plugutil/issues/63)) ([925ea8c](925ea8c))
* **Menu:** add more missing props ([SteamDeckHomebrew#60](https://github.com/shdwmtr/plugutil/issues/60)) [CI SKIP] ([678ba21](678ba21))
* **Menu:** add nested menu groups + more props ([SteamDeckHomebrew#30](https://github.com/shdwmtr/plugutil/issues/30)) ([4233128](4233128))
* **MenuItem:** add missing props ([SteamDeckHomebrew#59](https://github.com/shdwmtr/plugutil/issues/59)) ([c84a091](c84a091))
* **modal:** add more props, refactor ([26017e7](26017e7))
* **modal:** support for latest steamos preview ([5f0470c](5f0470c))
* **patcher:** rewrite to support multiple patches ([076d9eb](076d9eb))
* **plugin:** add alwaysRender ([2fc2060](2fc2060))
* **plugin:** api for patching existing routes ([5b29447](5b29447))
* **ProgressBar:** add new progress bars ([d9e4ff3](d9e4ff3))
* refactoring mostly complete ([cea315a](cea315a))
* reorderable list now saves on backout ([b1591f8](b1591f8))
* **ReorderableList:** add animations, clean up ([26fae13](26fae13))
* Reworked callServerMethod for better reusability ([f637f84](f637f84))
* **Router.tsx:** adds more methods to router ([SteamDeckHomebrew#9](https://github.com/shdwmtr/plugutil/issues/9)) ([602f93a](602f93a))
* **router:** expose GetQuickAccessTab and rename QuickAccessTabs to QuickAccessTab ([bf0c2b1](bf0c2b1))
* **routerhook:** add global components support ([215156d](215156d))
* **router:** types for steam router ([62bf0ea](62bf0ea))
* **serverAPI:** add FilePicker ([8eb921e](8eb921e))
* **ServerAPI:** add Toaster to serverAPI ([e2126af](e2126af))
* **sidebar-navigation:** add sidebar navigation component ([d8794ef](d8794ef))
* **static-classes:** add BasicAppDetailsSectionStylerClasses ([SteamDeckHomebrew#99](https://github.com/shdwmtr/plugutil/issues/99)) ([e27b638](e27b638))
* **static-classes:** add more css classes ([SteamDeckHomebrew#94](https://github.com/shdwmtr/plugutil/issues/94)) ([30e3194](30e3194))
* **StaticClasses:** add new GamepadUI classes ([3ca8c43](3ca8c43))
* support for non-interactable reordering ([dbd01b1](dbd01b1))
* support for user specified icon ([47a6fdd](47a6fdd))
* **Tabs:** initial tabs component, props, docs ([abbd3cd](abbd3cd))
* **textfield:** extract TextField component ([a3c1a7c](a3c1a7c))
* **toast:** add showToast/playSound to ToastData ([SteamDeckHomebrew#64](https://github.com/shdwmtr/plugutil/issues/64)) ([7ba1229](7ba1229))
* **typings:** add Navigate to router typings ([f124480](f124480))
* **Utilities:** add wrapReactType utility ([7cf45cf](7cf45cf))
* **utils:** add findInTree and findInReactTree ([b21dfcd](b21dfcd))
* **utils:** add joinClassNames util ([f34b9de](f34b9de))
* **utils:** add sleep util ([db64f34](db64f34))
* **utils:** add wrapReactClass ([d237bd4](d237bd4))

### BREAKING CHANGES

* **modal:** ModalRoot ->ConfirmModal
add the actual ModalRoot which does not contain buttons
* **patcher:** All usage of *Patch functions must now store the result and call .unpatch()
unpatch() has been removed.
* **components:** Toggle -> ToggleField Slider -> SliderField & add Toggle component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants