Rename interaction terms #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly reordered). This change preserves the order of the coefficients as passed over from the models.
… also rename interaction terms based on the renamed variables that are interacted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two potential changes:
The first one is a small change concerning the default order of variables. Currently the variables are ordered alphabetically as after collecting the variables from different models duplicates are dropped by self.cov_names = sorted(set(covs)) which also causes the variables to be sorted alphabetically. I guess that in most cases users would prefer to keep the coefficient order given by the models as a default order so I adapted the code to drop duplicates without changing the order of coefficients. When I did that I realized that it would be convenient to always move the constant/intercept to the end of the table where it is displayed in most cases in papers.
The second one is a small extension of the rename_covariates method. Currently users have to separately rename also interaction terms which are generated automatically when using formulas such as "y~x*z". The extension simply looks up the names of x and z in the cov_map dictionary (when the user uses a dictionary and not a function) & names the interaction term accordingly (preserving Labels when they are used for special formatting) & allows the use to override the interaction symbol.