-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monero support #61
Conversation
elvece
commented
Apr 9, 2024
•
edited
Loading
edited
- Will need to rebase after Integration/2.0.0 #69 is merged
We are so, so close. One thing I found is if I disable Monero's RPC username/password in config, that change is not reflected here:
which affects how monero-wallet-rpc is built in the btcpay container and makes btcpay's wallet rpc fail. If monero disables it, can you blank the user/pass on config.yaml's altcoins.monero? Then we could probably even get rid of the requirement that credentials be enabled in monero's startos config, because monero itself and monero-wallet-rpc both don't care whether there's a password or not. Alternatively, we could not store this in the btcpay config and always look at /mnt/monerod/start9/config.yaml since it should be mounted if monero integration is turned on in btcpay. |
This has now been implemented and tested! Solution was to look at mounted monerod's config since we cannot optionally remove pointers for a case like this. |
I seem to have an issue building it:
I had just done the qemu raindance so I don't think that's the problem. |
Dockerfile
Outdated
@@ -10,7 +10,7 @@ RUN dotnet restore "utils/actions/actions.csproj" -a $TARGETARCH | |||
WORKDIR "/actions" | |||
RUN dotnet build "utils/actions/actions.csproj" -c Release -a $TARGETARCH -o /actions/build | |||
|
|||
FROM --platform=$BUILDPLATFORM btcpayserver/btcpayserver:1.13.5-altcoins | |||
FROM --platform=$BUILDPLATFORM btcpayserver/btcpayserver:2.0.0-altcoins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug in btcpayserver:2.0.0-altcoins perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, i changed something in the build, working on it
Awesome! Seems to work great! |
* monero-wallet-rpc service * Fix s6 services dependencies * fixup, tidyup things * Fixup permissions for monero-wallet-rpc * Final touchups I think * Final arrangements#git commit -S -m Final * Final touchups\! (minus the final, final ones\!) * update config to handle multiple altcoin options * fix check * whoops typo --------- Co-authored-by: Lucy Cifferello <[email protected]>
In further testing, came across a few bugs on a fresh setup with the wallet, I've resolved all but one, expressing as this log for the wallet rpc. It seems to be connected fine, but the error is concerning and I don't recall it previously existing: |
This persists on occasion in the monero wallet rpc logs, but it does not impact functionality at all. |
Can confirm, it was doing that on mine too. I'm not sure why exactly, it's as if the monero-wallet-rpc periodically loses contact with the monero daemon running in the monero container. But as you state, it doesn't seem to actually affect anything. Maybe it will be better in v036, but for now I'm not sure there's anything to do. I made a script to query the monero daemon from the btcpay container to try and just confirm that that's what's happening by seeing if the times when it is unavailable match up with what's in the btcpay log. I'll share the results here. |