Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightHouse Dependency issue fixed #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ajay-joshi-mtr
Copy link

No description provided.

@Ajay-joshi-mtr Ajay-joshi-mtr changed the title LightHouse Dependecy issue fixed LightHouse Dependency issue fixed Dec 24, 2022
@TBG-FR TBG-FR mentioned this pull request Feb 13, 2023
@TBG-FR
Copy link

TBG-FR commented Feb 13, 2023

Bump 👍 🔥

@TBG-FR
Copy link

TBG-FR commented Feb 13, 2023

Using docker-compose build I got

#0 5.642 warning lighthouse > intl-messageformat > [email protected]: We've written a new parser that's 6x faster and is backwards compatible. Please use @formatjs/icu-messageformat-parser
#0 7.718 [2/4] Fetching packages...
#0 19.62 error [email protected]: The engine "node" is incompatible with this module. Expected version ">=16.16". Got "14.21.2"

So I think we could even edit the Dockerfile to use 16.x

- RUN curl -sL https://deb.nodesource.com/setup_12.x > node_install.sh
- RUN curl -sL https://deb.nodesource.com/setup_14.x > node_install.sh
+ RUN curl -sL https://deb.nodesource.com/setup_16.x > node_install.sh

Copy link

@gnovaro gnovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants