-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor the module to independently manage services and scale out in HA #344
Draft
rush-skills
wants to merge
40
commits into
StackStorm:master
Choose a base branch
from
cernops:refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bishopbm1 Could you please look at the PR, do you have any feedback or pointers on this change? |
Wow this is awesome!!! I'm going to get this on some of my internal machines and test it out! will report back my findings! |
@bishopbm1 Thanks! Did you get a chance to test it out on your systems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR breaks the existing structure of this puppet module where a single file held all the configuration of all the components of stackstorm (server.pp), this breaks it down into various folders to make it more modular and reusable
Currently, the following new folders are added:
config
with all configuration parametersdependency
for all 3rd party dependencies that need to be installedcomponent
for each stackstorm component/serviceprofile/ha
to break down server installation pieces and make them scalable (for normal/upstream installs)