properly categorizing EXPIRETIME and PEXPIRETIME (#2593)

* properly categorizing EXPIRETIME and PEXPIRETIME * release notes
StackExchange · Nov 21, 2023 · 79e8346 · 79e8346
1 parent 3ff58cc
commit 79e8346
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
@@ -8,7 +8,7 @@ Current package versions:
 
 ## Unreleased
 
-No pending unreleased changes.
+- Fix [#2593](https://github.com/StackExchange/StackExchange.Redis/pull/2593): `EXPIRETIME` and `PEXPIRETIME` miscategorized as `PrimaryOnly` commands causing them to fail when issued against a read-only replica.
 
 ## 2.7.4
 

diff --git a/src/StackExchange.Redis/Enums/RedisCommand.cs b/src/StackExchange.Redis/Enums/RedisCommand.cs
@@ -272,7 +272,6 @@ internal static bool IsPrimaryOnly(this RedisCommand command)
             case RedisCommand.DEL:
             case RedisCommand.EXPIRE:
             case RedisCommand.EXPIREAT:
-            case RedisCommand.EXPIRETIME:
             case RedisCommand.FLUSHALL:
             case RedisCommand.FLUSHDB:
             case RedisCommand.GEOSEARCHSTORE:
@@ -304,7 +303,6 @@ internal static bool IsPrimaryOnly(this RedisCommand command)
             case RedisCommand.PERSIST:
             case RedisCommand.PEXPIRE:
             case RedisCommand.PEXPIREAT:
-            case RedisCommand.PEXPIRETIME:
             case RedisCommand.PFADD:
             case RedisCommand.PFMERGE:
             case RedisCommand.PSETEX:
@@ -368,6 +366,7 @@ internal static bool IsPrimaryOnly(this RedisCommand command)
             case RedisCommand.EVALSHA_RO:
             case RedisCommand.EXEC:
             case RedisCommand.EXISTS:
+            case RedisCommand.EXPIRETIME:
             case RedisCommand.GEODIST:
             case RedisCommand.GEOHASH:
             case RedisCommand.GEOPOS:
@@ -402,6 +401,7 @@ internal static bool IsPrimaryOnly(this RedisCommand command)
             case RedisCommand.MONITOR:
             case RedisCommand.MULTI:
             case RedisCommand.OBJECT:
+            case RedisCommand.PEXPIRETIME:
             case RedisCommand.PFCOUNT:
             case RedisCommand.PING:
             case RedisCommand.PSUBSCRIBE: