Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the V3 logic from
HandleCurrentTimeSliceAllNotesAndSlidersDidFinishTimeSlice
. Both custom placed notes with arcs and default V3 placement now properly assign scoring type achieving parity with PC.Tested on:
https://beatleader.xyz/leaderboard/global/33647x71/21
https://beatleader.xyz/leaderboard/global/3bef7xxx97/3
Issues I left:
Approximately
in the hook file. Where should I put it or maybe there is an existing function equivalent?