Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed processing V3 sliders #84

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

NSGolova
Copy link
Contributor

Implemented the V3 logic from HandleCurrentTimeSliceAllNotesAndSlidersDidFinishTimeSlice. Both custom placed notes with arcs and default V3 placement now properly assign scoring type achieving parity with PC.

Tested on:
https://beatleader.xyz/leaderboard/global/33647x71/21
https://beatleader.xyz/leaderboard/global/3bef7xxx97/3

Issues I left:

  • Placed Approximately in the hook file. Where should I put it or maybe there is an existing function equivalent?
  • Copy paste logic for reading NE json. I wanted to keep the logic both similar to the game and the previous style so it ended up with a bit of copy-paste.
  • CutDirectionAngleOffset logic from PC. It's absent in the original game code and in quest V2 implementation, so I'm not sure if I need to port it as well.

@Fernthedev Fernthedev merged commit fa5eb45 into StackDoubleFlow:master Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants