Fix wall fake glow #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables and fixes the fake glow on walls.
Obviously re-enabling fake glow looked dumb with no changes so I re-enabled Kaitlyn's fix which made all the glow ridiculously large (filling the whole headset FOV).
Seems like that was caused by negative wall durations causing very large in magnitude but negative wall lengths, so taking the abs of the length allowed things to look more reasonable again.
Zero-duration walls then had no outlines which also looked dumb so I made it so that the smallest dimension is clamped to 0.1f when calculating the edge size multiplier.
This led to the following result.