fix 3dmc

titrate/upperlimits.py

@@ -133,8 +133,12 @@ def pvalue(self, poi_ul, cl_type):
 
     def expected_uls(self):
         # scan for poi_ul median
+        if self.cl_type == "s+b":
+            target_ts = norm.ppf(1 - (1 - self.cl)) ** 2
+        if self.cl_type == "s":
+            target_ts = norm.ppf(1 - 0.5 * (1 - self.cl)) ** 2
+
         poi_ul = 1e-2
-        target_ts = norm.ppf(1 - 0.5 * (1 - self.cl)) ** 2
         while (ts := self.no_signal_statistic.evaluate(poi_ul)) < target_ts:
             poi_ul *= 2
 
@@ -170,7 +174,7 @@ def expected_uls(self):
 
     def compute_band(self, sigma, n_sigma, cl_type):
         if cl_type == "s+b":
-            return sigma * (norm.ppf(self.cl) + n_sigma)
+            return sigma * (norm.ppf(1 - (1 - self.cl)) + n_sigma)
         elif cl_type == "s":
             return sigma * (norm.ppf(1 - (1 - self.cl) * norm.cdf(n_sigma)) + n_sigma)
 

titrate/validation.py

@@ -6,8 +6,8 @@
 from astropy.table import QTable
 from astropy.units import Quantity
 from gammapy.astro.darkmatter import DarkMatterAnnihilationSpectralModel
-from gammapy.modeling.models import SkyModel
 from gammapy.modeling import Fit
+from gammapy.modeling.models import SkyModel
 
 from titrate.datasets import AsimovMapDataset, AsimovSpectralDataset
 from titrate.statistics import QMuTestStatistic, QTildeMuTestStatistic, kstest