Add favicon support, configuring and processing methods #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Final icons should contain a hash in their path. |
|
Sweet! This is a nice bonus.
So many awesome new features, do you plan on updating pwa-demo? It'd be
great to see these in action.
…On Thu, Apr 25, 2024, 2:12 PM Florent Morselli ***@***.***> wrote:
Final icons should contain a hash in their path.
—
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQIHSJQIJIP5RMVAUQTY7FBRZAVCNFSM6AAAAABGZLWO5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXHA3TMOBSG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Spomky
force-pushed
the
features/favicons
branch
3 times, most recently
from
efd300b to
4b789c8
Compare
Spomky
force-pushed
the
features/favicons
branch
from
4b789c8 to
826b264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition introduces favicon support, including the configuration and processing methods. A DTO for favicons was added along with config definition. Moreover, the relevant processing logic was also implemented in both GDImageProcessor and ImagickImageProcessor. Other affected components have been adjusted accordingly to accommodate these changes.
Target branch: 1.2.x
Resolves issue #66