Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With logging muted #6

Merged
merged 29 commits into from
Oct 24, 2024
Merged

With logging muted #6

merged 29 commits into from
Oct 24, 2024

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Oct 21, 2024 •
edited
Loading

This PR adds a block functions called withLoggingMuted to allow muting logging not only in test methods (for which we have the @MuteLogging annotation), but for arbitrary blocks of code which produce unwanted console output.

Other notable changes

  • SystemOutputTest was deprecated in favor of tapConsole API from Logging Testlib.
  • The Testing class now uses Spine Logger.
  • Methods related to Flogger were deprecated in LogTruth.
  • Tests related to muting of console output were migrated to Kotlin.
  • config was updated.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 23, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review October 24, 2024 16:23
@alexander-yevsyukov alexander-yevsyukov added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit a89553b Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armiol armiol armiol approved these changes

Assignees

@alexander-yevsyukov alexander-yevsyukov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-yevsyukov @armiol