MMA-8008 Error and warning with Plesk v18.0.50 (#60)

* Fix get-domain-list status check

* Update domain/exists response check to avoid warnings

* Show an error when addAlias fails

plib/library/Plesk/ApiClient.php

@@ -63,7 +63,7 @@ public function getCustomerDomains($resellerId)
 
                 $response = $this->xmlapi($request);
 
-                if ("ok" == $response->customer->{"get-domain-list"}->{result}->{status}) {
+                if ("ok" == $response->customer->{"get-domain-list"}->result->status) {
                     foreach ($response->customer->children() as $customerDomains) {
                         foreach ($customerDomains->result->domains as $domain) {
                             foreach ($domain->children() as $item) {

plib/library/SpamFilter/Api.php

@@ -101,7 +101,8 @@ public function checkDomain($domain)
 
         try {
             $response = $this->call("/api/domain/exists/domain/$domain");
-            $result = (1 == json_decode($response, true)['present']);
+            $decoded_response = json_decode($response, true);
+            $result = $decoded_response && 1 === $decoded_response['present'];
         } catch (Exception $e) {
             $response = "Error: " . $e->getMessage() . " | Code: " . $e->getCode();
             $result = false;

plib/library/SpamFilter/Domain.php

@@ -163,6 +163,15 @@ public function protectAlias($updateDns = true)
             $this->pleskDomain->getDomain()
         );
 
+        if (!$domainAddOk) {
+            throw new \RuntimeException(
+                sprintf(
+                    "Failed to add the domain '%s' as an alias into the spamfilter",
+                    htmlentities($this->pleskDomain->getDomain(), ENT_QUOTES, 'UTF-8')
+                )
+            );
+        }
+
         if ($domainAddOk && !empty($spamfilterMx)) {
             $this->dns->replaceDomainsMxRecords($this->pleskDomain, $spamfilterMx);
         }