-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add gpu vram #780
Feat/add gpu vram #780
Conversation
To be done: Adjust flavor name parser, pretty printer, generator. Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Looks good overall.
|
Interesting. I still know the old spelling nVidia from the 90s as well. It can be seen on old chips, for instance: https://de.m.wikipedia.org/wiki/Nvidia#/media/Datei%3A6600GT_GPU.jpg |
Also mention older generations ... Signed-off-by: Kurt Garloff <[email protected]>
Spelling fixed. |
Lets merge this PR here first and I will create another PR to fill up the table with more GPUs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, LGTM.
For detailed information regarding why this PR was made: #546 |
Signed-off-by: Kurt Garloff <[email protected]>
One true fix (broken link) And tweak the double-space test for tolerating two spaces after a | in a table. Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Well, I still need to adjust the parser, generator, pretty-printer in the code to accept/generate the new syntax before merging. |
Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Matthias commits, I again went through all documents and found some more things which should be changed.
@cah-patrickthiem Please perform the changes yourself. Kurt is on vacation, and he won't mind. |
Just for a bit better readability. Signed-off-by: Kurt Garloff <[email protected]>
h on the SMs/CUs/EUs: High frequency h on the VRAM: High bandwidth Again, this is really only to differentiate if a vendor has several otherwise similar models that have a material difference in frequency or bandwidth, such as e.g. a GDDR6 vs an HBM2e veriant ... or a low-power, low-frequency variant. Signed-off-by: Kurt Garloff <[email protected]>
You're speaking in mysteries, @cah-patrickthiem here.
I did change the wording in the meaning of From my perspective this is ready to be merged, but happy to see additional refinement if you have any ... |
Sorry, usually I/we handle it like so, that the reviewer is not supposed to push anything to the PR to be reviewed, therefore I did not do this but planned to do it after Matthias told me its ok. You were just quicker. Nevertheless, I also think we can merge it, yes. |
Thanks, @cah-patrickthiem and @mbuechse to get this over the finish line! |
Preliminary:
Please check whether that incremental change is the small step that we agreed upon in the last team meeting.
It keeps the current scheme intact -- it's certification preserving, thus no new version required.
We may reconsider the flavor naming more fundamentally at some point in the future and maybe change direction from the systematic naming, but this is a major deviation and needs more work and preparation.
Related to #366