Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant clouds table #778

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

mbuechse
Copy link
Contributor

Part of #672.

@mbuechse mbuechse requested a review from garloff October 10, 2024 21:06
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for leaving a link here to the other (authoritative) location.
One piece of feedback from @manuela-urban : She is missing the colorful green passed or red failed signage.
On the other hand we have more information now, as we can see all the scopes that pass, which I consider a plus.
Maybe a combination would be three columns:
Previous scpoes | Current scopes | Future scopes
v3* PASS(green) | v4 PASS (green) | v5 FAIL(red)

Or is that too much information?

Anyhow, it's a possible future improvment, certainly not required to merge this one.

@mbuechse
Copy link
Contributor Author

@garloff Thanks. I think this is a helpful remark. We should address this, however, it's too far removed from this PR. I would open an additional issue for that. I wouldn't want to introduce so many columns, though. My idea would be to insert an Emoji (green or red) in front of the version list. The emoji would be green if the version list contains any version that is effective or "warn", otherwise it's red. This way, it's immediately apparent where one has to look for problems ;)

@garloff
Copy link
Member

garloff commented Oct 15, 2024

Agreed:

  • Yes, this is a separate PR
  • Just a green color in front of passed versions that are currently effective would give the wanted visual clues.

Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse mbuechse force-pushed the feat/deduplicate_clouds_table branch from fb65788 to 16065c6 Compare October 15, 2024 13:02
@mbuechse mbuechse merged commit e2922ed into main Oct 15, 2024
6 of 7 checks passed
@mbuechse mbuechse deleted the feat/deduplicate_clouds_table branch October 15, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants