Debugger: Auto-save debug workspace periodically to prevent data loss…

… if a crash occurs
SourMesen · Dec 26, 2023 · 4168583 · 4168583
1 parent f545e41
commit 4168583
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 2 deletions.
diff --git a/UI/Debugger/Breakpoints/BreakpointManager.cs b/UI/Debugger/Breakpoints/BreakpointManager.cs
@@ -1,4 +1,5 @@
-using Mesen.Interop;
+using Mesen.Debugger.Utilities;
+using Mesen.Interop;
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
@@ -64,7 +65,9 @@ public static void AddBreakpoints(List<Breakpoint> breakpoints)
 
 		public static void RemoveBreakpoint(Breakpoint bp)
 		{
-			_breakpoints.Remove(bp);
+			if(_breakpoints.Remove(bp)) {
+				DebugWorkspaceManager.AutoSave();
+			}
 			RefreshBreakpoints(bp);
 		}
 
@@ -80,6 +83,7 @@ public static void AddBreakpoint(Breakpoint bp)
 		{
 			if(!_breakpoints.Contains(bp)) {
 				_breakpoints.Add(bp);
+				DebugWorkspaceManager.AutoSave();
 			}
 			RefreshBreakpoints(bp);
 		}
@@ -149,6 +153,7 @@ public static bool EnableDisableBreakpoint(AddressInfo info, CpuType cpuType)
 			Breakpoint? breakpoint = BreakpointManager.GetMatchingBreakpoint(info, cpuType);
 			if(breakpoint != null) {
 				breakpoint.Enabled = !breakpoint.Enabled;
+				DebugWorkspaceManager.AutoSave();
 				RefreshBreakpoints();
 				return true;
 			}

diff --git a/UI/Debugger/Utilities/DebugWorkspaceManager.cs b/UI/Debugger/Utilities/DebugWorkspaceManager.cs
@@ -176,6 +176,16 @@ public static void Save(bool releaseWorkspace = false)
 				_workspace = null;
 			}
 		}
+
+		private static DateTime _previousAutoSave = DateTime.MinValue;
+		public static void AutoSave()
+		{
+			//Automatically save when changing a label/breakpoint/watch to avoid losing progress if a crash occurs
+			if((DateTime.Now - _previousAutoSave).TotalSeconds >= 60) {
+				_workspace?.Save(_path, _romInfo.CpuTypes);
+				_previousAutoSave = DateTime.Now;
+			}
+		}
 	}
 
 	public class CpuDebugWorkspace

diff --git a/UI/Debugger/Views/BreakpointListView.axaml.cs b/UI/Debugger/Views/BreakpointListView.axaml.cs
@@ -55,6 +55,7 @@ private void OnCellClick(DataBoxCell cell)
 						}
 					}
 
+					DebugWorkspaceManager.AutoSave();
 					BreakpointManager.RefreshBreakpoints();
 				}
 			}

diff --git a/UI/Debugger/WatchManager.cs b/UI/Debugger/WatchManager.cs
@@ -1,6 +1,7 @@
 using Avalonia.Media;
 using Mesen.Config;
 using Mesen.Debugger.Labels;
+using Mesen.Debugger.Utilities;
 using Mesen.Interop;
 using ReactiveUI;
 using ReactiveUI.Fody.Helpers;
@@ -226,6 +227,7 @@ public void UpdateWatch(int index, string expression)
 				}
 				WatchChanged?.Invoke(null, EventArgs.Empty);
 			}
+			DebugWorkspaceManager.AutoSave();
 		}
 
 		public void RemoveWatch(params int[] indexes)

diff --git a/UI/Debugger/Windows/BreakpointEditWindow.axaml.cs b/UI/Debugger/Windows/BreakpointEditWindow.axaml.cs
@@ -3,6 +3,7 @@
 using Avalonia.Interactivity;
 using Avalonia.Markup.Xaml;
 using Mesen.Controls;
+using Mesen.Debugger.Utilities;
 using Mesen.Debugger.ViewModels;
 using Mesen.Utilities;
 using System;

diff --git a/UI/Debugger/Windows/LabelEditWindow.axaml.cs b/UI/Debugger/Windows/LabelEditWindow.axaml.cs
@@ -3,6 +3,7 @@
 using Avalonia.Interactivity;
 using Avalonia.Markup.Xaml;
 using Mesen.Debugger.Labels;
+using Mesen.Debugger.Utilities;
 using Mesen.Debugger.ViewModels;
 using Mesen.Interop;
 using Mesen.Utilities;
@@ -58,6 +59,7 @@ public static async void EditLabel(CpuType cpuType, Control parent, CodeLabel la
 				model.Commit();
 				LabelManager.DeleteLabel(label, false);
 				LabelManager.SetLabel(copy ?? label, true);
+				DebugWorkspaceManager.AutoSave();
 			}
 
 			model.Dispose();
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,6 +55,7 @@ private void OnCellClick(DataBoxCell cell) @@
     						}
     					}
+    					DebugWorkspaceManager.AutoSave();
     					BreakpointManager.RefreshBreakpoints();
     				}
     			}
@@ Expand Down @@