SONARJAVA-4973 Fix FP on S1118 with Lombok @UtilityClass in automatic analysis #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-tylenda-sonarsource
changed the title
tomasz-tylenda-sonarsource
requested a review
from dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource
requested changes
Dec 12, 2024
java-checks/src/main/java/org/sonar/java/filters/LombokFilter.java
Outdated
Show resolved
Hide resolved
java-checks/src/main/java/org/sonar/java/filters/LombokFilter.java
Outdated
Show resolved
Hide resolved
java-checks/src/main/java/org/sonar/java/filters/LombokFilter.java
Outdated
Show resolved
Hide resolved
java-checks/src/main/java/org/sonar/java/filters/LombokFilter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We should use some formatting before committing this new code
There was a problem hiding this comment.
I did reformat the code in the IDE. Please let me know if you think my IDE is misconfigured.
java-checks/src/main/java/org/sonar/java/filters/LombokFilter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
dorian-burihabwa-sonarsource
approved these changes
Dec 13, 2024
tomasz-tylenda-sonarsource
requested a review
from dorian-burihabwa-sonarsource
tomasz-tylenda-sonarsource
force-pushed
the
tt/S1118-lombok-utility-class
branch
from
105c70c to
55de6e9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonarsource.atlassian.net/browse/SONARJAVA-4973