-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARJAVA-4436 Fix FP on S2095 when using @lombok.Cleanup #4957
Conversation
30a91de
to
df2b24c
Compare
df2b24c
to
991f333
Compare
74310e1
to
a20a1cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking additional time to look into this. Let's make sure we work well when semantics is broken
...olic-execution-plugin/src/test/java/org/sonar/java/se/checks/UnclosedResourcesCheckTest.java
Outdated
Show resolved
Hide resolved
...execution/java-symbolic-execution-plugin/src/test/files/se/UnclosedResourcesLombokCheck.java
Outdated
Show resolved
Hide resolved
...symbolic-execution-plugin/src/main/java/org/sonar/java/se/checks/UnclosedResourcesCheck.java
Outdated
Show resolved
Hide resolved
…t/files/se/UnclosedResourcesLombokCheck.java Co-authored-by: Dorian Burihabwa <[email protected]>
...olic-execution-plugin/src/test/java/org/sonar/java/se/checks/UnclosedResourcesCheckTest.java
Outdated
Show resolved
Hide resolved
...olic-execution-plugin/src/test/java/org/sonar/java/se/checks/UnclosedResourcesCheckTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks again for diving into this complex issue and crafting a simple but efficient fix!
https://sonarsource.atlassian.net/browse/SONARJAVA-4436