Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARJAVA-4436 Fix FP on S2095 when using @lombok.Cleanup #4957

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

tomasz-tylenda-sonarsource
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking additional time to look into this. Let's make sure we work well when semantics is broken

…t/files/se/UnclosedResourcesLombokCheck.java

Co-authored-by: Dorian Burihabwa <[email protected]>
Co-authored-by: Dorian Burihabwa <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks again for diving into this complex issue and crafting a simple but efficient fix!

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit 2d6bb09 into master Dec 11, 2024
17 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/lombok-cleanup-S2095 branch December 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants