Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARJAVA-4263 Fix FP on S2325 when method requires type parameter from parent class. #4954

Merged
merged 9 commits into from
Dec 10, 2024
Merged

SONARJAVA-4263 Fix FP on S2325 when method requires type parameter from parent class. #4954

merged 9 commits into from
Dec 10, 2024

Conversation

tomasz-tylenda-sonarsource
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Dec 6, 2024 •
edited by jira bot
Loading

SONARJAVA-4263

Fix FP on S2325 when method requires type parameter from parent class.

dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I think there is room for a little improvements but this change already solves the problem quite nicely!

java-checks-test-sources/default/src/main/java/checks/StaticMethodCheckSample.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StaticMethodCheck.java Outdated Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StaticMethodCheck.java Show resolved Hide resolved
java-checks/src/main/java/org/sonar/java/checks/StaticMethodCheck.java Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit 8e787b5 into master Dec 10, 2024
14 of 15 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/return-type-static branch December 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasz-tylenda-sonarsource @dorian-burihabwa-sonarsource