SONARJAVA-4424 add methods annotated with @Test to the list of testNg test methods

[erwan-serandour]

SONARJAVA-4424

Part of

[dorian-burihabwa-sonarsource]

Nice work. There is a couple of things to revisit here:

1. Simplify the lambda to find test members in a TestNG class
2. Clarify which test case is raising a FP here (and if it cannot be fixed, clearly mark it as an FP when semantic is incomplete)

[dorian-burihabwa-sonarsource]

We can change the name of the class to TestNGDoesNotRequirePublicTestMethods or add a compliant comment explaining why this case is not an issue

[dorian-burihabwa-sonarsource]

Can we extract the second test into its own method and simplify the code?

Suggested change

	if (members.noneMatch(member -> {
	boolean annotatedWithTest = isTestFieldOrMethod(member);
	boolean publicMethod = member.isMethodSymbol() && member.isPublic() && !member.isStatic() && !"<init>".equals(member.name());
	return annotatedWithTest || publicMethod;
	})) {
	if (members.noneMatch(member -> isTestFieldOrMethod(member) || isPublicInstanceMethod(member)) {

[dorian-burihabwa-sonarsource]

It looks like we are only testing on methods because we have isMethodSymbol in both branches. Can we return early if the member is not a method?

Suggested change

	boolean annotatedWithTest = member.isMethodSymbol() && member.metadata().annotations().stream().anyMatch(isTestNgAnnotation);
	boolean publicMethod = member.isMethodSymbol() && member.isPublic() && !member.isStatic() && !"<init>".equals(member.name());
	return annotatedWithTest || publicMethod;
	if (!member.isMethodSymbol()) {
	return false;
	}
	boolean annotatedWithTest = member.metadata().annotations().stream().anyMatch(isTestNgAnnotation);
	boolean publicMethod = member.isPublic() && !member.isStatic() && !"<init>".equals(member.name());
	return annotatedWithTest || publicMethod;

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube