Skip to content

Commit

Permalink
Disable S127, enable S1488
Browse files Browse the repository at this point in the history
  • Loading branch information
irina-batinic-sonarsource committed Jun 18, 2024
1 parent 98b78ee commit c03f58f
Show file tree
Hide file tree
Showing 7 changed files with 51 additions and 13 deletions.
20 changes: 20 additions & 0 deletions its/ruling/src/test/resources/commons-beanutils/java-S1488.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,24 @@
528,
570
],
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/BasicDynaBeanTestCase.java": [
986
],
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/BeanMapTestCase.java": [
181,
208,
226
],
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/DynaBeanUtilsTestCase.java": [
1237
],
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/DynaPropertyUtilsTestCase.java": [
2614
],
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/bugs/Jira347TestCase.java": [
150
],
"commons-beanutils:commons-beanutils:src/test/java/org/apache/commons/beanutils2/memoryleaktests/MemoryLeakTestCase.java": [
528
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
"org.eclipse.jetty:jetty-project:jetty-http/src/main/java/org/eclipse/jetty/http/QuotedQualityCSV.java": [
183
],
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/GZIPContentDecoderTest.java": [
381,
395
],
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/Utf8HttpWriter.java": [
81
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@
187,
194
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/HttpOutputTest.java": [
177
]
}
7 changes: 0 additions & 7 deletions its/ruling/src/test/resources/eclipse-jetty/java-S127.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
"org.eclipse.jetty:jetty-project:jetty-http/src/main/java/org/eclipse/jetty/http/QuotedQualityCSV.java": [
183
],
"org.eclipse.jetty:jetty-project:jetty-http/src/test/java/org/eclipse/jetty/http/GZIPContentDecoderTest.java": [
381,
395
],
"org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/Utf8HttpWriter.java": [
81
],
Expand Down Expand Up @@ -66,8 +62,5 @@
],
"org.eclipse.jetty:jetty-project:jetty-util/src/main/java/org/eclipse/jetty/util/security/Password.java": [
182
],
"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/component/ContainerLifeCycleTest.java": [
570
]
}
9 changes: 9 additions & 0 deletions its/ruling/src/test/resources/eclipse-jetty/java-S1488.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@
187,
194
],
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/HttpOutputTest.java": [
177
],
"org.eclipse.jetty:jetty-project:jetty-util/src/main/java/org/eclipse/jetty/util/resource/JarResource.java": [
131
],
"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/RolloverFileOutputStreamTest.java": [
53
],
"org.eclipse.jetty:jetty-project:jetty-util/src/test/java/org/eclipse/jetty/util/ssl/X509Test.java": [
93
]
}
17 changes: 17 additions & 0 deletions its/ruling/src/test/resources/sonar-server/java-S1488.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/component/ComponentServiceUpdateKeyTest.java": [
207
],
"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/computation/task/projectanalysis/scm/ScmInfoImplTest.java": [
132
],
"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/issue/ws/AssignActionTest.java": [
268
],
"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/notification/email/AlertsEmailTemplateTest.java": [
120
],
"org.sonarsource.sonarqube:sonar-server:src/test/java/org/sonar/server/permission/ws/template/SearchTemplatesActionTest.java": [
65
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,7 @@ public final class CheckList {
FinalClassCheck.class,
FinalizeFieldsSetCheck.class,
FloatEqualityCheck.class,
ForLoopCounterChangedCheck.class,
ForLoopFalseConditionCheck.class,
ForLoopIncrementAndUpdateCheck.class,
ForLoopIncrementSignCheck.class,
Expand Down Expand Up @@ -1200,7 +1201,6 @@ public final class CheckList {
CollectionIsEmptyCheck.class,
CompareObjectWithEqualsCheck.class,
StringConcatenationInLoopCheck.class,
ImmediatelyReturnedVariableCheck.class,
DisallowedThreadGroupCheck.class,
ClassVariableVisibilityCheck.class,
PublicStaticFieldShouldBeFinalCheck.class,
Expand Down Expand Up @@ -1308,8 +1308,8 @@ public final class CheckList {
EmptyMethodsCheck.class,
EmptyStatementUsageCheck.class,
FixmeTagPresenceCheck.class,
ForLoopCounterChangedCheck.class,
HiddenFieldCheck.class,
ImmediatelyReturnedVariableCheck.class,
LambdaOptionalParenthesisCheck.class,
MethodIdenticalImplementationsCheck.class,
MethodNameSameAsClassCheck.class,
Expand Down

0 comments on commit c03f58f

Please sign in to comment.