Remove state from S1181 (#4756)

SonarSource · Apr 8, 2024 · a6890ba · a6890ba
1 parent c2b29aa
commit a6890ba
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/java-checks/src/main/java/org/sonar/java/checks/CatchOfThrowableOrErrorCheck.java b/java-checks/src/main/java/org/sonar/java/checks/CatchOfThrowableOrErrorCheck.java
@@ -42,7 +42,6 @@
 public class CatchOfThrowableOrErrorCheck extends IssuableSubscriptionVisitor {
 
   private static final String JAVA_LANG_THROWABLE = "java.lang.Throwable";
-  private final TryBlockVisitor tryBlockVisitor = new TryBlockVisitor();
 
   @Override
   public List<Tree.Kind> nodesToVisit() {
@@ -52,7 +51,7 @@ public List<Tree.Kind> nodesToVisit() {
   @Override
   public void visitNode(Tree tree) {
     TryStatementTree tryStatement = (TryStatementTree) tree;
-    tryBlockVisitor.reset();
+    TryBlockVisitor tryBlockVisitor = new TryBlockVisitor();
     tryStatement.block().accept(tryBlockVisitor);
     if (tryBlockVisitor.containsExplicitThrowable || tryBlockVisitor.containsUnresolvableCall) {
       return;
@@ -126,13 +125,8 @@ private boolean isGuavaCloserRethrow(MethodInvocationTree mit) {
   }
 
   private static class TryBlockVisitor extends BaseTreeVisitor {
-    private boolean containsExplicitThrowable;
-    private boolean containsUnresolvableCall;
-
-    public void reset() {
-      containsUnresolvableCall = false;
-      containsExplicitThrowable = false;
-    }
+    private boolean containsExplicitThrowable = false;
+    private boolean containsUnresolvableCall = false;
 
     @Override
     public void visitMethodInvocation(MethodInvocationTree tree) {