SONARJAVA-2209 Fix handling of (-1) (#1342) (#1343)

SonarSource · Mar 27, 2017 · 041066d · 041066d
1 parent fee94e8
commit 041066d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/java-checks/src/main/java/org/sonar/java/checks/DeadStoreCheck.java b/java-checks/src/main/java/org/sonar/java/checks/DeadStoreCheck.java
@@ -198,7 +198,7 @@ private static boolean isUsualDefaultValue(ExpressionTree tree) {
         return "0".equals(value) || "1".equals(value);
       case UNARY_MINUS:
       case UNARY_PLUS:
-        return isUsualDefaultValue(((UnaryExpressionTree) tree).expression());
+        return isUsualDefaultValue(((UnaryExpressionTree) expr).expression());
       default:
         return false;
     }

diff --git a/java-checks/src/test/files/checks/DeadStoreCheck.java b/java-checks/src/test/files/checks/DeadStoreCheck.java
@@ -301,7 +301,7 @@ int testIntLiterals() {
     b = 0;        // Noncompliant
     b = 1;        // Noncompliant
     int c = +1;   // Compliant
-    int d = -(1); // Compliant
+    int d = (-1); // Compliant
     int e = -1;   // Compliant
 
     // Only int literals are excluded