JS-498 Add runtime telemetry #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
saberduck
reviewed
Dec 16, 2024
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServer.java
Outdated
Show resolved
Hide resolved
saberduck
reviewed
Dec 16, 2024
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServer.java
Outdated
Show resolved
Hide resolved
saberduck
requested changes
Dec 16, 2024
saberduck
reviewed
Dec 17, 2024
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServer.java
Outdated
Show resolved
Hide resolved
|
saberduck
reviewed
Dec 18, 2024
| @@ -111,8 +111,7 @@ void analyzeFiles(List<InputFile> inputFiles) throws IOException { | |||
| ) | |||
| ); | |||
| } | |||
| var telemetry = bridgeServer.getTelemetry(); | |||
| new PluginTelemetry(context).reportTelemetry(telemetry); | |||
| new PluginTelemetry(context, bridgeServer).reportTelemetry(); | |||
There was a problem hiding this comment.
optional - I would only pass value from bridgeServer.getTelemtry() instead of passing the whole bridgeServer
There was a problem hiding this comment.
This way, if telemetry is not available or not necessary to compute for some reason, we wouldn't be computing it.
saberduck
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-498
Adding runtime telemetry as per the bonus part of the MMF.
Refactoring the code a bit, so only querying the node server, if telemetry is actually enabled.