Stop using legacy keys (#1925)

javascript-checks/src/main/java/org/sonar/javascript/checks/ArrayConstructorsCheck.java

@@ -26,9 +26,11 @@
 import org.sonar.plugins.javascript.api.tree.expression.IdentifierTree;
 import org.sonar.plugins.javascript.api.tree.expression.NewExpressionTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "ArrayAndObjectConstructors")
+@Rule(key = "S1528")
+@DeprecatedRuleKey(ruleKey = "ArrayAndObjectConstructors")
 public class ArrayConstructorsCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Use a literal instead of the Array constructor.";

javascript-checks/src/main/java/org/sonar/javascript/checks/ConditionalCommentCheck.java

@@ -27,9 +27,11 @@
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxToken;
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxTrivia;
 import org.sonar.plugins.javascript.api.visitors.SubscriptionVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "ConditionalComment")
+@Rule(key = "S1532")
+@DeprecatedRuleKey(ruleKey = "ConditionalComment")
 public class ConditionalCommentCheck extends SubscriptionVisitorCheck {
 
   private static final String MESSAGE = "Refactor your code to avoid using Internet Explorer's conditional comments.";

javascript-checks/src/main/java/org/sonar/javascript/checks/ConditionalOperatorCheck.java

@@ -23,9 +23,11 @@
 import org.sonar.javascript.checks.annotations.JavaScriptRule;
 import org.sonar.plugins.javascript.api.tree.expression.ConditionalExpressionTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "ConditionalOperator")
+@Rule(key = "S1774")
+@DeprecatedRuleKey(ruleKey = "ConditionalOperator")
 public class ConditionalOperatorCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Convert this usage of the ternary operator to an \"if\"/\"else\" structure.";

javascript-checks/src/main/java/org/sonar/javascript/checks/ContinueStatementCheck.java

@@ -23,9 +23,11 @@
 import org.sonar.javascript.checks.annotations.JavaScriptRule;
 import org.sonar.plugins.javascript.api.tree.statement.ContinueStatementTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "ContinueStatement")
+@Rule(key = "S909")
+@DeprecatedRuleKey(ruleKey = "ContinueStatement")
 public class ContinueStatementCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Remove this \"continue\" statement.";

javascript-checks/src/main/java/org/sonar/javascript/checks/DuplicateFunctionArgumentCheck.java

@@ -29,9 +29,11 @@
 import org.sonar.plugins.javascript.api.tree.declaration.ParameterListTree;
 import org.sonar.plugins.javascript.api.tree.expression.IdentifierTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "DuplicateFunctionArgument")
+@Rule(key = "S1536")
+@DeprecatedRuleKey(ruleKey = "DuplicateFunctionArgument")
 public class DuplicateFunctionArgumentCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Rename the duplicated function parameter \"%s\".";

javascript-checks/src/main/java/org/sonar/javascript/checks/DuplicatePropertyNameCheck.java

@@ -41,9 +41,11 @@
 import org.sonar.plugins.javascript.api.tree.flow.FlowSimplePropertyDefinitionKeyTree;
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxToken;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "DuplicatePropertyName")
+@Rule(key = "S1534")
+@DeprecatedRuleKey(ruleKey = "DuplicatePropertyName")
 public class DuplicatePropertyNameCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Rename or remove duplicate property name '%s'.";

javascript-checks/src/main/java/org/sonar/javascript/checks/ForInCheck.java

@@ -29,9 +29,11 @@
 import org.sonar.plugins.javascript.api.tree.statement.ForObjectStatementTree;
 import org.sonar.plugins.javascript.api.tree.statement.StatementTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "ForIn")
+@Rule(key = "S1535")
+@DeprecatedRuleKey(ruleKey = "ForIn")
 public class ForInCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Restrict what this loop acts on by testing each property.";

javascript-checks/src/main/java/org/sonar/javascript/checks/HtmlCommentsCheck.java

@@ -27,9 +27,11 @@
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxToken;
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxTrivia;
 import org.sonar.plugins.javascript.api.visitors.SubscriptionVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "HtmlComments")
+@Rule(key = "S1531")
+@DeprecatedRuleKey(ruleKey = "HtmlComments")
 public class HtmlCommentsCheck extends SubscriptionVisitorCheck {
 
   private static final String MESSAGE = "Replace this HTML-style comment by a standard comment";

javascript-checks/src/main/java/org/sonar/javascript/checks/NamedFunctionExpressionCheck.java

@@ -23,9 +23,11 @@
 import org.sonar.javascript.checks.annotations.JavaScriptRule;
 import org.sonar.plugins.javascript.api.tree.expression.FunctionExpressionTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "NamedFunctionExpression")
+@Rule(key = "S1517")
+@DeprecatedRuleKey(ruleKey = "NamedFunctionExpression")
 public class NamedFunctionExpressionCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Make this function anonymous by removing its name: 'function() {...}'.";

javascript-checks/src/main/java/org/sonar/javascript/checks/OctalNumberCheck.java

@@ -24,9 +24,11 @@
 import org.sonar.plugins.javascript.api.tree.Tree;
 import org.sonar.plugins.javascript.api.tree.expression.LiteralTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "OctalNumber")
+@Rule(key = "S1314")
+@DeprecatedRuleKey(ruleKey = "OctalNumber")
 public class OctalNumberCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Replace the value of the octal number (%s) by its decimal equivalent (%s).";

javascript-checks/src/main/java/org/sonar/javascript/checks/ParsingErrorCheck.java

@@ -23,10 +23,12 @@
 import org.sonar.javascript.checks.annotations.JavaScriptRule;
 import org.sonar.javascript.checks.annotations.TypeScriptRule;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
 @TypeScriptRule
-@Rule(key = "ParsingError")
+@Rule(key = "S2260")
+@DeprecatedRuleKey(ruleKey = "ParsingError")
 public class ParsingErrorCheck extends DoubleDispatchVisitorCheck {
 
 }

javascript-checks/src/main/java/org/sonar/javascript/checks/SwitchWithoutDefaultCheck.java

@@ -27,9 +27,11 @@
 import org.sonar.plugins.javascript.api.tree.statement.SwitchClauseTree;
 import org.sonar.plugins.javascript.api.tree.statement.SwitchStatementTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "SwitchWithoutDefault")
+@Rule(key = "S131")
+@DeprecatedRuleKey(ruleKey = "SwitchWithoutDefault")
 public class SwitchWithoutDefaultCheck extends DoubleDispatchVisitorCheck {
 
   private static final String ADD_DEFAULT_MESSAGE = "Add a \"default\" clause to this \"switch\" statement.";

javascript-checks/src/main/java/org/sonar/javascript/checks/TooManyBreakOrContinueInLoopCheck.java

@@ -43,9 +43,11 @@
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
 import org.sonar.plugins.javascript.api.visitors.IssueLocation;
 import org.sonar.plugins.javascript.api.visitors.PreciseIssue;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "TooManyBreakOrContinueInLoop")
+@Rule(key = "S135")
+@DeprecatedRuleKey(ruleKey = "TooManyBreakOrContinueInLoop")
 public class TooManyBreakOrContinueInLoopCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Reduce the total number of \"break\" and \"continue\" statements in this loop to use one at most.";

javascript-checks/src/main/java/org/sonar/javascript/checks/TrailingCommaCheck.java

@@ -28,12 +28,14 @@
 import org.sonar.plugins.javascript.api.tree.expression.ArrayLiteralTree;
 import org.sonar.plugins.javascript.api.tree.expression.ObjectLiteralTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * http://stackoverflow.com/questions/7246618/trailing-commas-in-javascript
  */
 @JavaScriptRule
-@Rule(key = "TrailingComma")
+@Rule(key = "S1537")
+@DeprecatedRuleKey(ruleKey = "TrailingComma")
 public class TrailingCommaCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Remove this trailing comma.";

javascript-checks/src/main/java/org/sonar/javascript/checks/TrailingCommentCheck.java

@@ -29,9 +29,11 @@
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxToken;
 import org.sonar.plugins.javascript.api.tree.lexical.SyntaxTrivia;
 import org.sonar.plugins.javascript.api.visitors.SubscriptionVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "TrailingComment")
+@Rule(key = "S139")
+@DeprecatedRuleKey(ruleKey = "TrailingComment")
 public class TrailingCommentCheck extends SubscriptionVisitorCheck {
 
   private static final String MESSAGE = "Move this trailing comment on the previous empty line.";

javascript-checks/src/main/java/org/sonar/javascript/checks/TrailingWhitespaceCheck.java

@@ -31,9 +31,11 @@
 import org.sonar.plugins.javascript.api.visitors.JavaScriptFile;
 import org.sonar.plugins.javascript.api.visitors.LineIssue;
 import org.sonar.plugins.javascript.api.visitors.SubscriptionVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "TrailingWhitespace")
+@Rule(key = "S1131")
+@DeprecatedRuleKey(ruleKey = "TrailingWhitespace")
 public class TrailingWhitespaceCheck extends SubscriptionVisitorCheck {
 
   private static final String MESSAGE = "Remove the useless trailing whitespaces at the end of this line.";

javascript-checks/src/main/java/org/sonar/javascript/checks/UnreachableCodeCheck.java

@@ -41,9 +41,11 @@
 import org.sonar.plugins.javascript.api.tree.statement.VariableDeclarationTree;
 import org.sonar.plugins.javascript.api.visitors.PreciseIssue;
 import org.sonar.plugins.javascript.api.visitors.SubscriptionVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "UnreachableCode")
+@Rule(key = "S1736")
+@DeprecatedRuleKey(ruleKey = "UnreachableCode")
 public class UnreachableCodeCheck extends SubscriptionVisitorCheck {
 
   private static final String MESSAGE = "Remove this code after the \"%s\" statement.";

javascript-checks/src/main/java/org/sonar/javascript/checks/WithStatementCheck.java

@@ -23,9 +23,11 @@
 import org.sonar.javascript.checks.annotations.JavaScriptRule;
 import org.sonar.plugins.javascript.api.tree.statement.WithStatementTree;
 import org.sonar.plugins.javascript.api.visitors.DoubleDispatchVisitorCheck;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @JavaScriptRule
-@Rule(key = "WithStatement")
+@Rule(key = "S1321")
+@DeprecatedRuleKey(ruleKey = "WithStatement")
 public class WithStatementCheck extends DoubleDispatchVisitorCheck {
 
   private static final String MESSAGE = "Remove this use of \"with\".";

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/TrailingWhitespace.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1131.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1131",
-  "sqKey": "TrailingWhitespace",
+  "sqKey": "S1131",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/SwitchWithoutDefault.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S131.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-131",
-  "sqKey": "SwitchWithoutDefault",
+  "sqKey": "S131",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/OctalNumber.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1314.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-1314",
-  "sqKey": "OctalNumber",
+  "sqKey": "S1314",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/WithStatement.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1321.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1321",
-  "sqKey": "WithStatement",
+  "sqKey": "S1321",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/TooManyBreakOrContinueInLoop.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S135.json

@@ -12,7 +12,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-135",
-  "sqKey": "TooManyBreakOrContinueInLoop",
+  "sqKey": "S135",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/TrailingComment.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S139.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-139",
-  "sqKey": "TrailingComment",
+  "sqKey": "S139",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/NamedFunctionExpression.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1517.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1517",
-  "sqKey": "NamedFunctionExpression",
+  "sqKey": "S1517",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/ArrayAndObjectConstructors.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1528.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1528",
-  "sqKey": "ArrayAndObjectConstructors",
+  "sqKey": "S1528",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/HtmlComments.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1531.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1531",
-  "sqKey": "HtmlComments",
+  "sqKey": "S1531",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/ConditionalComment.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1532.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-1532",
-  "sqKey": "ConditionalComment",
+  "sqKey": "S1532",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/DuplicatePropertyName.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1534.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-1534",
-  "sqKey": "DuplicatePropertyName",
+  "sqKey": "S1534",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/ForIn.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1535.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-1535",
-  "sqKey": "ForIn",
+  "sqKey": "S1535",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/DuplicateFunctionArgument.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1536.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-1536",
-  "sqKey": "DuplicateFunctionArgument",
+  "sqKey": "S1536",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/TrailingComma.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1537.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1537",
-  "sqKey": "TrailingComma",
+  "sqKey": "S1537",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/UnreachableCode.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1736.json

@@ -12,7 +12,7 @@
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-1763",
-  "sqKey": "UnreachableCode",
+  "sqKey": "S1736",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/ConditionalOperator.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1774.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-1774",
-  "sqKey": "ConditionalOperator",
+  "sqKey": "S1774",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/ParsingError.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2260.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2260",
-  "sqKey": "ParsingError",
+  "sqKey": "S2260",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/ContinueStatement.json → javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S909.json

@@ -11,7 +11,7 @@
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-909",
-  "sqKey": "ContinueStatement",
+  "sqKey": "S909",
   "compatibleLanguages": [
     "JAVASCRIPT"
   ],