Fix missing virtual destructors.

SolidWallOfCode · Apr 2, 2020 · fe1bec1 · fe1bec1
1 parent aca189d
commit fe1bec1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/swoc++/CMakeLists.txt b/swoc++/CMakeLists.txt
@@ -46,7 +46,7 @@ set(CC_FILES
 
 add_library(swoc++ STATIC ${CC_FILES})
 #add_compile_options(-Wall -Wextra -Werror -Wno-unused-parameter -Wno-format-truncation -Wno-stringop-overflow -Wno-invalid-offsetof)
-target_compile_options(swoc++ PRIVATE -Wall -Wextra -Werror -Wno-unused-parameter -Wno-format-truncation -Wno-stringop-overflow -Wno-invalid-offsetof)
+target_compile_options(swoc++ PRIVATE -Wall -Wextra -Werror -Wnon-virtual-dtor -Wno-unused-parameter -Wno-stringop-overflow)
 
 # Not quite sure how this works, but I think it generates one of two paths depending on the context.
 # That is, the generator functions return non-empty strings only in the corresponding context.

diff --git a/swoc++/include/swoc/bwf_base.h b/swoc++/include/swoc/bwf_base.h
@@ -766,6 +766,8 @@ namespace bwf
   class ArgPack
   {
   public:
+    virtual ~ArgPack() = default; /// Force virtual destructor for subclasses.
+
     /** Get argument at index @a idx.
      *
      * @param idx Argument index.