Add affected test computation parameters for emop #91
Conversation
| includeVariables = includeVariablesTemp; | ||
| updateChecksums = updateChecksumsTemp; | ||
| computeImpactedMethods = computeImpactedMethodsTemp; |
There was a problem hiding this comment.
why so much temps? and what are the temps for?
There was a problem hiding this comment.
Like the parameter should be passed to the superclass of MonitorHybridMojo.java which is ImpactedHybridMojo.java which is later passed to HybridMojo.java (in STARTS). This is the method I managed to come up with to tackle this parameter passing.
| @@ -30,9 +30,12 @@ public class ImpactedHybridMojo extends HybridMojo { | |||
| */ | |||
| protected boolean debug; | |||
|
|
|||
| protected boolean computeAffectedTests; | |||
There was a problem hiding this comment.
@pengyuejiang and I thought that this flag is for deciding whether to additionally compute affected classes. But the name suggests that you are computing affected tests. Can you please clarify? Also, can you please point us to a usage of this field?
There was a problem hiding this comment.
Yes it is used to control whether we want to additionally compute affected classes or not. The setComputeAffectedTests() method further down is actually in STARTS and this boolean flag is used to enable/disable the relevant parameter in STARTS.
This PR adds a small change to be able to control whether we want to compute affected test classes or not from emop since the computation happens in STARTS actually.