Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: parser and secret tests #3192

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

@sfc-gh-fbudzynski sfc-gh-fbudzynski commented Nov 12, 2024

Changes

  • added ../ to primary_connection documentation
  • added invalid test cases for ParseCommaSeparatedAccountIdentifierArray
  • changed secretsData() function parameters

Test Plan

  • acceptance tests for secrets
  • unit tests for parser

References

references to comments:

Copy link

Integration tests failure for a677547ac24c7b3f4d470b6f5fa3541341581fc0

Copy link

Integration tests failure for 1954a03cd888d63c70081f23e98438652c28cfad

@sfc-gh-fbudzynski sfc-gh-fbudzynski merged commit 5ec9c86 into main Nov 14, 2024
8 of 9 checks passed
@sfc-gh-fbudzynski sfc-gh-fbudzynski deleted the chore-parse-account-id branch November 14, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants