Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dns available through sansshell proxy. #510

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

sfc-gh-mwalas
Copy link
Collaborator

At least during local development followinghttps://github.com/Snowflake-Labs/sansshell?tab=readme-ov-file#build-and-run the DNS resolution fails when calling out through proxy

$ go run ./cmd/sanssh --proxy=localhost:50043 --targets=localhost:50042 dns lookup www.example.com
Dns lookup failure for target localhost:50042 (0) - error - rpc error: code = Internal desc = got reply error from stream. Code: InvalidArgument Message: unknown method /Dns.Lookup/Lookup

while it succeeds when contacting server directly

go run ./cmd/sanssh --targets=localhost dns lookup www.example.com
93.184.215.14

I suspect this is due to lack of linking of dns in

// Import services here to make them proxy-able

@sfc-gh-mwalas sfc-gh-mwalas marked this pull request as ready for review November 12, 2024 10:54
@sfc-gh-mwalas sfc-gh-mwalas merged commit a76925d into main Nov 12, 2024
7 checks passed
@sfc-gh-mwalas sfc-gh-mwalas deleted the mwalas-fix-dns-proxying branch November 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants