Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to set FDB-related env vars from a file. #292

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

sfc-gh-srhodes
Copy link
Collaborator

This is conceptually similar to FDBCLIEnvList, but it's based on reading from a file instead of reading from environmental variables from the sansshell process. Sansshell often runs in a way that has minimal environmental variables, so foundationdb-specific variables may not be around. We silently omit the file when it's absent.

This is conceptually similar to FDBCLIEnvList, but it's based on reading from a file instead of reading from environmental variables from the sansshell process. Sansshell often runs in a way that has minimal environmental variables, so foundationdb-specific variables may not be around. We silently omit the file when it's absent.
Copy link

@sfc-gh-sgwydir sfc-gh-sgwydir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@sfc-gh-ssudakovich sfc-gh-ssudakovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ssudakovich sfc-gh-ssudakovich merged commit 870d0c3 into main Aug 8, 2023
3 checks passed
@sfc-gh-ssudakovich sfc-gh-ssudakovich deleted the srhodes-fdb-env branch August 8, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants