Prevent dns rebinding attacks in httpoverrpc proxy.
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-srhodes
force-pushed
the
rebinding
branch
from
49dd38c
to
224ba0f
Compare
Proxying is intended to be a safe way to access possibly-sensitive resources. An attacker could theoretically use DNS rebinding (https://en.wikipedia.org/wiki/DNS_rebinding) to create a malicious domain that tricks a web browser into using a proxied connection. Let's change the defaults to eliminate that risk by ensuring that we're using localhost or accessing directly via an ip address.
sfc-gh-srhodes
force-pushed
the
rebinding
branch
from
224ba0f
to
19e636f
Compare
sfc-gh-elinardi
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxying is intended to be a safe way to access possibly-sensitive resources. An attacker could theoretically use DNS rebinding (https://en.wikipedia.org/wiki/DNS_rebinding) to create a malicious domain that tricks a web browser into using a proxied connection. Let's change the defaults to eliminate that risk by ensuring that we're using localhost or accessing directly via an ip address.