fix: onClose event trigger CLOSE_EVENT #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@onClose
event call the_toggleModal()
function without triggering theCLOSE_EVENT
.When an user just click outside the modal to close it, the event is not triggered here :
web3modal-vue/src/Web3ModalVue.vue
Line 84 in cc95d43
Resolution
Change the handleback function to
@onClose="onClose"