Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiversion support to ExplosiveTool#createNewBlockExplodeEvent #4245

Closed
wants to merge 7 commits into from

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Sep 24, 2024

Description

Add multiversion support to ExplosiveTool#createNewBlockExplodeEvent using reflection.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

This doesn't build yet due to tests of MockBukkit failing

@Intybyte Intybyte requested review from a team as code owners September 24, 2024 09:49
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@WalshyDev WalshyDev force-pushed the walshy/mc-1.21 branch 4 times, most recently from a5de53e to 9f175bf Compare October 1, 2024 00:34
@WalshyDev
Copy link
Member

ported into #4248

@WalshyDev WalshyDev closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants