Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[choreo] Upgrade to Tauri v2 #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[choreo] Upgrade to Tauri v2 #489

wants to merge 1 commit into from

Conversation

calcmogul
Copy link
Member

@calcmogul calcmogul commented Jun 14, 2024 •
edited
Loading

Fixes #453.

@calcmogul
Copy link
Member Author

The app has the following issues on my Linux machine:

  1. keyboard shortcuts don't work until the window is in focus (and sometimes not even then)
  2. the file open dialog crashes if I press Escape

Issue 1 is happening for me with 2024.2.2 as well, so it's probably not Tauri v2 causing it. If someone confirms neither of these issues occurs on Windows, I'm OK with merging this PR.

@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch from 3b8ce57 to f410383 Compare June 17, 2024 20:55
@calcmogul
Copy link
Member Author

Issue 1 was reproduced on Windows but not issue 2.

@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 46fa6f0 to a58b1d5 Compare June 24, 2024 23:49
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 9 times, most recently from 29b0888 to f8eb257 Compare July 11, 2024 18:18
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 06cf02c to 7386e72 Compare July 17, 2024 05:47
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 9 times, most recently from a06664d to b440e96 Compare August 5, 2024 06:41
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 63df449 to 71935df Compare August 15, 2024 15:36
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 3 times, most recently from ed91bd8 to 54d007c Compare August 22, 2024 04:00
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 5 times, most recently from d6b078a to f51b127 Compare November 20, 2024 05:17
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 3 times, most recently from 4f69875 to b698298 Compare November 28, 2024 20:14
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 3 times, most recently from b6bbe01 to 0a1f812 Compare December 9, 2024 16:30
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 9 times, most recently from cf26c21 to db63523 Compare December 22, 2024 02:34
@calcmogul
Copy link
Member Author

calcmogul commented Dec 27, 2024 •
edited
Loading

Minimum reproducible example for crash on exit

choreo-tauri-v2-crash.zip

  1. Run run.sh
  2. Click either button of the dialog that opens to close it
  3. Click the main window close button
  4. The app will crash on exit

Any use of a dialog from TypeScript will cause the application to crash on exit. If one isn't opened, the app does not crash.

Fixes for crash on exit

The plumbing may be worse, but we could try opening dialogs from Rust instead: https://v2.tauri.app/plugin/dialog/#rust

tauri-dialog transitively uses gtk-rs for GTK bindings, which is no longer maintained: PolyMeilex/rfd#227. As for other backend options:

JS | 6995AM — 12/23/24, 10:42 PM
rfd would use XDG Portals, but those don't support message dialogs apparently, which is 4 of our 5 dialogs

Fixes for file open dialog crashing on escape press

This was reported in PolyMeilex/rfd#219 and fixed upstream. The fix hasn't appeared in a release yet.

@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 7 times, most recently from aa346e4 to ca99647 Compare January 9, 2025 18:03
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch from ca99647 to 9927566 Compare January 12, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Tauri 2.0
3 participants
@calcmogul @spacey-sooty @oh-yes-0-fps