Merge pull request #2095 from Skyscanner/donburi/DON-934-bpkselect-co…

…rnerradius DON-934 Update BPKSelect corner radius to 12
Skyscanner · Oct 30, 2024 · 4137f9b · 4137f9b
2 parents 3fdf67a + 620177d
commit 4137f9b
Show file tree

Hide file tree

Showing 23 changed files with 2 additions and 2 deletions.
diff --git a/Backpack-SwiftUI/Select/Classes/BPKSelect.swift b/Backpack-SwiftUI/Select/Classes/BPKSelect.swift
@@ -38,9 +38,9 @@ struct CustomPickerStyle: ViewModifier {
         .padding(.horizontal, .base)
         .padding(.vertical, verticalPadding)
         .background(.surfaceDefaultColor)
-        .clipShape(RoundedRectangle(cornerRadius: .xs))
+        .clipShape(RoundedRectangle(cornerRadius: .md))
         .disabled(pickerState.isDisabled)
-        .outline(pickerState.borderColor, cornerRadius: .xs)
+        .outline(pickerState.borderColor, cornerRadius: .md)
     }
 }
 

diff --git a/...iftUI/Tests/Select/__Snapshots__/SelectTests/test_defaultSettings.dark-mode.png b/...iftUI/Tests/Select/__Snapshots__/SelectTests/test_defaultSettings.dark-mode.png
diff --git a/...ftUI/Tests/Select/__Snapshots__/SelectTests/test_defaultSettings.light-mode.png b/...ftUI/Tests/Select/__Snapshots__/SelectTests/test_defaultSettings.light-mode.png
diff --git a/...ack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_defaultSettings.rtl.png b/...ack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_defaultSettings.rtl.png
diff --git a/...SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_disabledState.dark-mode.png b/...SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_disabledState.dark-mode.png
diff --git a/...wiftUI/Tests/Select/__Snapshots__/SelectTests/test_disabledState.light-mode.png b/...wiftUI/Tests/Select/__Snapshots__/SelectTests/test_disabledState.light-mode.png
diff --git a/Backpack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_disabledState.rtl.png b/Backpack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_disabledState.rtl.png
diff --git a/...-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_emptyOptions.dark-mode.png b/...-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_emptyOptions.dark-mode.png
diff --git a/...SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_emptyOptions.light-mode.png b/...SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_emptyOptions.light-mode.png
diff --git a/Backpack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_emptyOptions.rtl.png b/Backpack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_emptyOptions.rtl.png
diff --git a/...ck-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_errorState.dark-mode.png b/...ck-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_errorState.dark-mode.png
diff --git a/...k-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_errorState.light-mode.png b/...k-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_errorState.light-mode.png
diff --git a/Backpack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_errorState.rtl.png b/Backpack-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_errorState.rtl.png
diff --git a/...Tests/Select/__Snapshots__/SelectTests/test_selectOutOfBoundsItem.dark-mode.png b/...Tests/Select/__Snapshots__/SelectTests/test_selectOutOfBoundsItem.dark-mode.png
diff --git a/...ests/Select/__Snapshots__/SelectTests/test_selectOutOfBoundsItem.light-mode.png b/...ests/Select/__Snapshots__/SelectTests/test_selectOutOfBoundsItem.light-mode.png
diff --git a/...iftUI/Tests/Select/__Snapshots__/SelectTests/test_selectOutOfBoundsItem.rtl.png b/...iftUI/Tests/Select/__Snapshots__/SelectTests/test_selectOutOfBoundsItem.rtl.png
diff --git a/...ftUI/Tests/Select/__Snapshots__/SelectTests/test_selectSecondItem.dark-mode.png b/...ftUI/Tests/Select/__Snapshots__/SelectTests/test_selectSecondItem.dark-mode.png
diff --git a/...tUI/Tests/Select/__Snapshots__/SelectTests/test_selectSecondItem.light-mode.png b/...tUI/Tests/Select/__Snapshots__/SelectTests/test_selectSecondItem.light-mode.png
diff --git a/...ck-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_selectSecondItem.rtl.png b/...ck-SwiftUI/Tests/Select/__Snapshots__/SelectTests/test_selectSecondItem.rtl.png
diff --git a/screenshots/iPhone-swiftui_select___picker_closed_dm.png b/screenshots/iPhone-swiftui_select___picker_closed_dm.png
diff --git a/screenshots/iPhone-swiftui_select___picker_closed_lm.png b/screenshots/iPhone-swiftui_select___picker_closed_lm.png
diff --git a/screenshots/iPhone-swiftui_select___picker_open_dm.png b/screenshots/iPhone-swiftui_select___picker_open_dm.png
diff --git a/screenshots/iPhone-swiftui_select___picker_open_lm.png b/screenshots/iPhone-swiftui_select___picker_open_lm.png