[KOA-6229] Add viewbox to all JS icons and spinners #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for SVGs to scale, we need to add a
viewBox
attribute. Due to an issue withsvgo
library, theremoveViewBox
plugin which is enabled by default cannot be disabled. This plugin only runs if theviewBox
width
andheight
values are equal to thewidth
andheight
attributes on the svg and so one solution is to remove thewidth
andheight
attributes altogether. We are still using thestyle
attribute to set thewidth
andheight
so it should not have any impact visually.Changes:
width
andheight
attributes from all JS iconsviewBox
attribute to all LG icons (SM icons already have aviewBox
)viewBox
andstyle
to all JS spinnerswidth
andheight
attributes on SVG spinners withviewBox
(this matches all SVG icons)Remember to include the following changes:
UNRELEASED.md
(See How to write a good changelog entry)README.md