Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix intents-related docs #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bilal2453
Copy link
Contributor

  1. setIntents parameter type changed to number since it is never resolved in a meaningful way.
  2. setIntents paramter changed to optional, as it will default to 0.
  3. changed Intents-Resolvables to Intents-Resolvable because that is what Discordia uses everywhere.

@SinisterRectus
Copy link
Owner

I already said I didn't want to change this. 1 and 3 are intentional. 2 is fine.

@Bilal2453
Copy link
Contributor Author

Bilal2453 commented Nov 5, 2024

Sorry, seems like it was a miscommunication! I thought you wanted this.

Then nothing needs to be changed here, but there is a bit of a consistency problem to describe:

Currently in the Input resolution wiki page we list all resolvers, the way those Input resolution entries are named is by removing the -Resolvable suffix, leaving the resolver name, so for example Permission-Resolvable becomes Permission, Permissions-Resolvable becomes Permissions etc. If we use the same pattern here, we end up with two entries with the same name, Intents and Intents, because the difference is in the suffix which we currently remove. Intents-Resolvable vs Intents-Resolvables.

If we use the same pattern we use right now, you will end up with two entries having the same name like this:
image

Edit: Just noticed that we have other types not currently in the wiki with a similar problem:

  • Message-ID-Resolvables
  • Role-ID-Resolvables
  • Permissions-Resolvables (we have Permissions-Resolvable documented although)

Should probably rework the input resolution wiki page instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants