Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple-Contacts: Added support for relations #1649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rlieger
Copy link

@rlieger rlieger commented Mar 28, 2023

A ContactRelation can be used to express a relation to another person (e.g. spouse, friend, colleague) within a contact. This concept is supported by both Android (ContactContract.Relation) and vCard 4.0 (RELATED) and should thus also be supported in SimpleContacts.
Note: Like most fields, displaying relations for a contact is optional and can be enabled/disabled in the manage-visable-fields dialog. It is disabled by default, so to see my code in action be sure to enable it...

I have added suitable code for both the base types (in Simple-Commons) and the application logic for the viewing/editing the databases (in Simple-Contacts). Thus to obtain a working system, pulling both Simple-Commons and Simple-Contacts is necessary!

Roland Lieger added 2 commits March 27, 2023 18:33
…daughter) to be stored in contacts (both Android ContactContract and LocalContact).
@rlieger
Copy link
Author

rlieger commented Apr 20, 2023

This pull request was not handled for three weeks. I have since worked a lot on the code and hope to release an improved version within a week or two. I suggest that you skip this version and directly integrate the new version.

@naveensingh
Copy link
Contributor

hope to release an improved version within a week or two

then I guess this one can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants