Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to obsolete file names and wrong version numbering for backups #1374

Merged
merged 19 commits into from
Dec 5, 2024

Conversation

susanodd
Copy link
Collaborator

@susanodd susanodd commented Nov 7, 2024

Fixes to bak bak old style file names. Fixes a bug in the API that all backups are given version number 1.

  • Some of the code is still using (version * ".bak") extensions. That has been changed to the new format .bakNNNN

  • The logging has been repaired to only put a deleted video in the history, not all the reverted videos (those are still on the file system)

  • The renumbering of older backups has been updated so they get new version numbers

  • The retrieval of GlossVideo objects explicitly excludes subclass objects (only the prime videos are versioned)

The branch includes a minimum amount of code to achieve the goal: use the new format for file names.

Old file names can be repaired elsewhere (pull requests in other branches)

@susanodd

This comment was marked as outdated.

@vanlummelhuizen

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd susanodd requested a review from Jetske November 18, 2024 13:36
@susanodd susanodd changed the title #1373, 1356: Separate branch for fixes to bak bak reversion #1373, 1356: Fxes to reversion Nov 18, 2024
@vanlummelhuizen

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@uklomp

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd

This comment was marked as outdated.

@susanodd
Copy link
Collaborator Author

UPDATE @Woseseltops

On signbank-test you can

  • Use the Swagger API to upload videos
  • To confirm that the version numbers are being incremented (the bug on master/production sets them to 1)
  • Use Manage Datasets -> Manage Video Storage to inspect the paths of the gloss video objects

@susanodd

This comment was marked as outdated.

@susanodd susanodd changed the title #1373, 1356: Fxes to reversion Fixes to reversion obsolete file names in code Nov 30, 2024
@susanodd susanodd requested a review from Woseseltops December 5, 2024 06:07
@susanodd susanodd changed the title Fixes to reversion obsolete file names in code Fixes to obsolete file names for backups Dec 5, 2024
@susanodd susanodd changed the title Fixes to obsolete file names for backups Fixes to obsolete file names and wrong version numbering for backups Dec 5, 2024
Copy link
Collaborator

@Woseseltops Woseseltops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Nothing to complain about code wise.
  • Functionally, I tested as @susanodd describes and can confirm that using the API to upload multiple video files results in backups like this
0: glossvideo/NGT/WE/WEBCAM-2211.mp4, 1: glossvideo/NGT/WE/WEBCAM-2211.mp4.bak24466, 2: glossvideo/NGT/WE/WEBCAM-2211.mp4.bak10152

@susanodd susanodd merged commit 24f5853 into master Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants