-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to obsolete file names and wrong version numbering for backups #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paths that are wrong form
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
do not include mp4 in reverted videos.
susanodd
changed the title
#1373, 1356: Separate branch for fixes to bak bak reversion
#1373, 1356: Fxes to reversion
Nov 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
UPDATE @Woseseltops On signbank-test you can
|
This comment was marked as outdated.
This comment was marked as outdated.
susanodd
changed the title
#1373, 1356: Fxes to reversion
Fixes to reversion obsolete file names in code
Nov 30, 2024
susanodd
changed the title
Fixes to reversion obsolete file names in code
Fixes to obsolete file names for backups
Dec 5, 2024
susanodd
changed the title
Fixes to obsolete file names for backups
Fixes to obsolete file names and wrong version numbering for backups
Dec 5, 2024
Woseseltops
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nothing to complain about code wise.
- Functionally, I tested as @susanodd describes and can confirm that using the API to upload multiple video files results in backups like this
0: glossvideo/NGT/WE/WEBCAM-2211.mp4, 1: glossvideo/NGT/WE/WEBCAM-2211.mp4.bak24466, 2: glossvideo/NGT/WE/WEBCAM-2211.mp4.bak10152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to bak bak old style file names. Fixes a bug in the API that all backups are given version number 1.
Some of the code is still using
(version * ".bak")
extensions. That has been changed to the new format.bakNNNN
The logging has been repaired to only put a deleted video in the history, not all the reverted videos (those are still on the file system)
The renumbering of older backups has been updated so they get new version numbers
The retrieval of GlossVideo objects explicitly excludes subclass objects (only the prime videos are versioned)
The branch includes a minimum amount of code to achieve the goal: use the new format for file names.
Old file names can be repaired elsewhere (pull requests in other branches)