Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log startup errors to stderr #213

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Log startup errors to stderr #213

merged 3 commits into from
Jan 9, 2025

Conversation

n8maninger
Copy link
Member

@n8maninger n8maninger commented Jan 8, 2025

Makes it easier for scripts to parse startup issues

Fixes #203

Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed two log.Fatal in main.go, there's also 3 calls to it in gen.go which I took with me in renterd since it's also potentially a command that needs to be run from a script

@n8maninger
Copy link
Member Author

you missed two log.Fatal in main.go, there's also 3 calls to it in gen.go which I took with me in renterd since it's also potentially a command that needs to be run from a script

Did the ones in main.go, but I'm fine with the ones in gen.go since it's a build script.

@n8maninger n8maninger requested a review from peterjan January 9, 2025 15:26
@n8maninger n8maninger merged commit 3a76ce2 into master Jan 9, 2025
9 checks passed
@n8maninger n8maninger deleted the nate/log-to-stderr branch January 9, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Better sanitation on the bind port
2 participants