fix issues identified by golangci-lint

SiaFoundation · Dec 6, 2023 · 5a49750 · 5a49750
1 parent 987d6e3
commit 5a49750
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/internal/syncerutil/store.go b/internal/syncerutil/store.go
@@ -22,7 +22,7 @@ type EphemeralPeerStore struct {
 	mu    sync.Mutex
 }
 
-func (eps *EphemeralPeerStore) banned(peer string) bool {
+func (eps *EphemeralPeerStore) peerBanned(peer string) bool {
 	host, _, err := net.SplitHostPort(peer)
 	if err != nil {
 		return false // shouldn't happen
@@ -60,7 +60,7 @@ func (eps *EphemeralPeerStore) Peers() []string {
 	defer eps.mu.Unlock()
 	var peers []string
 	for p := range eps.peers {
-		if !eps.banned(p) {
+		if !eps.peerBanned(p) {
 			peers = append(peers, p)
 		}
 	}
@@ -102,7 +102,7 @@ func (eps *EphemeralPeerStore) Ban(peer string, duration time.Duration, reason s
 func (eps *EphemeralPeerStore) Banned(peer string) bool {
 	eps.mu.Lock()
 	defer eps.mu.Unlock()
-	return eps.banned(peer)
+	return eps.peerBanned(peer)
 }
 
 // NewEphemeralPeerStore initializes an EphemeralPeerStore.

diff --git a/internal/walletutil/manager.go b/internal/walletutil/manager.go
@@ -14,6 +14,7 @@ import (
 
 var errNoWallet = errors.New("wallet does not exist")
 
+// A ChainManager manages blockchain state.
 type ChainManager interface {
 	AddSubscriber(s chain.Subscriber, tip types.ChainIndex) error
 	RemoveSubscriber(s chain.Subscriber)

diff --git a/wallet/seed.go b/wallet/seed.go
@@ -128,14 +128,16 @@ outer:
 	for _, parent := range toSign {
 		for sigIndex, sig := range txn.Signatures {
 			if sig.ParentID == parent {
-				if addr, ok := sigAddr(parent); !ok {
+				addr, ok := sigAddr(parent)
+				if !ok {
 					return fmt.Errorf("ID %v not present in transaction", parent)
-				} else if index, ok := sav.addrs[addr]; !ok {
+				}
+				index, ok := sav.addrs[addr]
+				if !ok {
 					return fmt.Errorf("missing key for ID %v", parent)
-				} else {
-					SignTransaction(cs, txn, sigIndex, sav.seed.PrivateKey(index))
-					continue outer
 				}
+				SignTransaction(cs, txn, sigIndex, sav.seed.PrivateKey(index))
+				continue outer
 			}
 		}
 		return fmt.Errorf("signature %v not present in transaction", parent)

diff --git a/wallet/wallet.go b/wallet/wallet.go
@@ -228,6 +228,8 @@ type V2FileContract struct {
 	Outputs    []types.SiacoinElement             `json:"outputs,omitempty"`
 }
 
+// An EventTransaction is a relevant transaction that happened on the Sia
+// blockchain.
 type EventTransaction struct {
 	ID                types.TransactionID    `json:"id"`
 	SiacoinInputs     []types.SiacoinElement `json:"siacoinInputs"`
@@ -240,10 +242,14 @@ type EventTransaction struct {
 	Fee               types.Currency         `json:"fee"`
 }
 
+// An EventMinerPayout is a relevant miner payout that happened on the Sia
+// blockchain.
 type EventMinerPayout struct {
 	SiacoinOutput types.SiacoinElement `json:"siacoinOutput"`
 }
 
+// An EventMissedFileContract is a relevant missed file contract that happened
+// on the Sia blockchain.
 type EventMissedFileContract struct {
 	FileContract  types.FileContractElement `json:"fileContract"`
 	MissedOutputs []types.SiacoinElement    `json:"missedOutputs"`