Update core #123
Closed
Update core #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
commented
Dec 2, 2024
ChrisSchinnerl
requested review from
n8maninger and
lukechampine
and removed request for
n8maninger
ChrisSchinnerl
commented
Dec 2, 2024
| @@ -251,6 +247,15 @@ func TestFormContract(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| // validate contract signatures | |||
There was a problem hiding this comment.
@n8maninger I added this because it seems like the RPC result didn't contain the renter signature. Which led to the host persisting the contract with an invalid signature as well and RPCLatestRevision returning the revision without signature. Causing the renter to be unable to broadcast the revision since it wasn't signed.
There was a problem hiding this comment.
Did you fix the bug in the host? All I'm seeing is a change in the client RPC.
|
closing in favor of #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.