Take storage cost into account in RenewalCost #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
requested changes
Dec 10, 2024
ChrisSchinnerl
force-pushed
the
chris/fix-renewal-cost
branch
from
6e74872 to
453d965
Compare
ChrisSchinnerl
force-pushed
the
chris/fix-renewal-cost
branch
from
e24ae46 to
3e4d713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the failing tests in SiaFoundation/coreutils#134. Broadcasting the revision fails with
siacoin inputs (600274999999999999906047180800 H) do not equal outputs (600274999999999999910241484800 H)which seems to exactly match the storage cost. After verifying it by setting the storage price to 0, I confirmed that this change fixes the error.