This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Ssl support #1
Merged
Ssl support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klautcomputing
approved these changes
Jan 23, 2017
charlescng
approved these changes
Jan 27, 2017
| session, err = sock:sslhandshake(ctx.session, name, ctx.ssl_verify) | ||
| if not session then | ||
| peer_error(ctx, is_backup, id, peer, | ||
| "failed to do SSL handshake: ", name, ": ", err) |
There was a problem hiding this comment.
SSL handshake failed? failed to do SSL handshake sounds to me that it failed to initiate the handshake vs the handshake failed.
|
Any update? seems not yet released. and one thing, if upstream server verify cert, so, how could health check take a cert when do handshake? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/Shopify/traffic/issues/1101
The PR is the continuation/completion of openresty#5.
In this PR the comments to original PR are addressed(mainly session reuse and tests) and the code is rebased with the latest upstream.
One significant modification to the original PR is that now, the health check will fail if
ssl_verify = trueand the certificate verification fails./r @charlescng @klautcomputing @csfrancis
/cc @Shopify/traffic