Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary:
Modifies our existing color rules so they can accept alpha values.
What approach did you take?
I added alpha values to our color variables, and did an aggressive first pass at swapping out our
rgb
/rgba
values to ensure they support these new variables.rgb
definitions becomergba
, andrgba
rules use relative colors.We use hardcoded transparency values intensely throughout Dawn. In order to retain those, I'm using
color-mix
to apply them on top of the user-provided color alpha. It's admittedly weird, but lets us retain the current appearance + functionality of Dawn.Areas of improvement:
color-mix
function every time.Testing steps/scenarios