Improve Dev error details on extension validation #4853
+72
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success1942 tests passing in 884 suites. Report generated by 🧪jest coverage report action from b1e6082 |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+267
to
+271
| errors.forEach(async (error) => { | ||
| const on = error.on as {user_identifier: string} | ||
| const extension = options.app.allExtensions.find((ext) => ext.uid === on.user_identifier) | ||
| await printError(error.message, stdout, extension?.handle ?? 'dev-session') | ||
| }) |
There was a problem hiding this comment.
forEach with async operations won't wait for all promises to resolve. Use Promise.all(errors.map()) to ensure all errors are processed before the function returns. This avoids potential race conditions and ensures proper error handling.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist