Make milestone list scrollable to support more milestones #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veger
force-pushed
the
scrollable-milestone-view
branch
2 times, most recently
from
182bd64
to
70a0b0a
Compare
Introduces a Bits class that is able to handle a dynamic amount of bits, instead of the 64 bits stored in the ulong.
veger
force-pushed
the
scrollable-milestone-view
branch
from
70a0b0a
to
3030b7b
Compare
shpaass
added a commit
to shpaass/yafc-ce
that referenced
this pull request
Feb 7, 2024
By embedding the milestone elements in a (virtual) scroll list, it will be possible to scroll them, which lifts the restriction of only allowing 60 milestones. Background: when playing extensive mod packs with lots of new/unknown technologies it is often hard to determine the research path to take. I find it convenient to add a lot (all) technologies to the milestone list, so YAFC shows which technologies I should research to unlock some item/recipe. This PR also fixes the original (probable) reason for this limitation: `ulong` can only hold 64 bits, and the Analyser uses bits to keep track of the dependencies of the milestones (and other objects). By replacing `ulong` with the custom build `Bits` class, this limitation is lifted. To be more confident that I did not break things, I first added a (simple) test suite for milestones. Then applied the changes and with minimal changed (had to use the `Bits` class now) the test suite still runs properly. Additionally, I made these changes more than a year ago (ShadowTheAge#203) and have been playing with loads/all (!) technologies of Pyanodons added to the milestones without issues:  Note that these (open) PRs are _very_ convenient combined with this feature: * ShadowTheAge#168 * ShadowTheAge#204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By embedding the milestone elements in a (virtual) scroll list, it will be possible to scroll them, which lifts the restriction of only allowing 60 milestones.
Edit: Fixed the original (probably) reason for this limitation:
ulongcan only hold 64 bits, and the Analyser uses bits to keep track of the dependencies of the milestones (and other objects). By replacingulongwith the custom buildBitsclass, this limitation is lifted.Background: when playing extensive mod packs with lots of new/unknown technologies it is often hard to determine the research path to take. I find it convenient to add a lot (all) technologies to the milestone list, so YAFC shows which technologies I should research to unlock some item/recipe.