-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default beacon overrides #200
Open
DaleStan
wants to merge
14
commits into
ShadowTheAge:master
Choose a base branch
from
DaleStan:default-beacon-overrides
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and allow selection of multiple objects by ctrl-clicking.
…display that item.
shpaass
added a commit
to shpaass/yafc-ce
that referenced
this pull request
Jun 29, 2024
This adds an intermediate level of beacon definitions; more general than the per-recipe-row definitions in the production table, but more specific than the whole-page settings. It was inspired by my desire to tell YAFC that the rows using IR3's small assemblers (~50 of my recipe rows) would be affected by three beacons, while (most of) the remaining recipe rows would be affected by four. On the module settings page, it adds this section. This allows you to specify the number of beacons, the beacon, and the beacon module on a per-building basis. ![image](https://user-images.githubusercontent.com/21223975/214727217-4dec35e3-ff3e-4581-9e59-71c8af0a2be9.png) "Add building override" lets you select any previously unselected crafter that accepts beacon effects. Left and right clicking open the same dialogs as clicking on the beacon and module settings above. This is a rebase and minor update (changes to the hint texts) of ShadowTheAge#200. I haven't used it recently (I primarily use it for megabasing), but I'm hoping it will be helpful for TURD beacons and similar. I'm hoping it will also satisfy requests like [this one](https://discord.com/channels/560199483065892894/1210135763422027837/1253101648872472649).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an intermediate level of beacon definitions; more general than the per-recipe-row definitions in the production table, but more specific than the whole-page settings.
It was inspired by my desire to tell YAFC that the rows using small assemblers (~50 of my recipe rows) would be affected by three beacons, while (most of) the remaining recipe rows would be affected by four.
On the module settings page, it adds this section. This allows you to specify the number of beacons, the beacon, and the beacon module on a per-building basis.
"Add building override" lets you select any previously unselected crafter that accepts beacon effects. Left and right clicking open the same dialogs as clicking on the beacon and module settings above.
It depends on #168 because the first time I clicked on "Add building override", I immediately asked "Why can't I select multiple buildings?"