Fix define for ESP32_RTOS and RTOS task function #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t least in platformio). Fix the name of the defined rtos task function and ensure the task never returns (fixes brownouut issue).
|
Hello @lekkimworld, Actually I'm trying to address the same issue in PR #10, as discuted in issue #8. Can you try the code from my fork to see if PIO is compatible with my changes or if adding a value to the define is necessary. Also, apparently the Telnet version is not working... Best, |
|
@2010019970909 yeah looks like we're addressing the same issue. I'm fine to close my PR as long as your PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The define for ESP32_RTOS must have a value for it to be picked up (at least in platformio). Fix the name of the defined rtos task function and ensure the task never returns (fixes brownout issue on ESP32).